Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vanity URLs] : Adding improvements #16333

Closed
jcastro-dotcms opened this issue Apr 3, 2019 · 5 comments

Comments

@jcastro-dotcms
Copy link
Contributor

commented Apr 3, 2019

Reported via Support: https://dotcms.zendesk.com/agent/tickets/97747
Reproducible in customer environment running dotCMS 4.3.3

Adding some improvements to the way Vanity URLs are loaded into memory after a Vanity URL has been updated and/or a cache flush.

@jcastro-dotcms jcastro-dotcms self-assigned this Apr 3, 2019

jcastro-dotcms added a commit that referenced this issue Apr 4, 2019

#16333 : When initializing Vanity URLs upon startup or cache flush, r…
…ead from DB instead of reading from the ES index as it may be not fully updated yet.
@jcastro-dotcms

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

PR: #16337

Please review and test this as many times as possible.

@jgambarios jgambarios added this to the Cody Current milestone Apr 4, 2019

jdotcms added a commit that referenced this issue Apr 16, 2019

jdotcms added a commit that referenced this issue Apr 16, 2019

#16333 when the secondary cache is repopulate, the previous elements …
…on the primary cache were orphan, now the elements on the current secondary cache are removed before override the secondary cache

jgambarios added a commit that referenced this issue Apr 23, 2019

Issue 16333 vanity urls adding improvements2 (#16413)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16333 : When initializing Vanity URLs upon startup or cache flush, read from DB instead of reading from the ES index as it may be not fully updated yet.

* #16333 adding small changes

* #16333 when the secondary cache is repopulate, the previous elements on the primary cache were orphan, now the elements on the current secondary cache are removed before override the secondary cache
@jgambarios

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

PR: #16413

@wezell

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

** A Test **

  1. deactivating indexes
  2. flush cache
  3. see if vanity still work
@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

After trying the test of the last comment, if you don't have active indexes we are unable to resolve the vanity and we are showing a blank page, also we have the following error on logs
ST: https://gist.github.com/bryanboza/4bd32ada605c311fba7c730866e170d5

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

ok, after the @wezell approval seems we are ok for now

@bryanboza bryanboza moved this from REX to Done in QA Apr 24, 2019

@wezell wezell closed this Apr 30, 2019

@wezell wezell added this to Done in Enterprise Services Issues via automation Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.