Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems setting existing fields as required #16376

Closed
bryanboza opened this issue Apr 11, 2019 · 2 comments

Comments

Projects
3 participants
@bryanboza
Copy link
Contributor

commented Apr 11, 2019

Describe the bug

We have a problem when you have a content type with some fields, and you change the properties of any of those to make this required after you try to leave this field in blank saving a content, we continue having the same error even though you set a valid value

Steps to reproduce the behavior:

  1. Create a new content type.
  2. Add a Title field (all boxes checked - required, indexed, etc.)
  3. Add a Select field. with the following values, and leave all boxes (required etc.) unchecked.
|
0.1|0.1
0.2|0.2
0.3|0.3
  1. Add 2 content items with titles but no "Version" value.
  2. Add a 3rd content item with both a title and a Version value.
  3. Change the "Version" Select field to make it required. (No other boxes checked).
  4. Try to change the "Version" value in the first 2 content items you created (in step #4).

Expected behavior

We need be able to set the values and save without problems

Screenshots

Here a video: https://screencast.com/t/jYEBqquHN

Desktop (please complete the following information):

Tested on master // Postgres // FF

@bryanboza bryanboza changed the title Problems enabling the required property of existing fields Problems setting existing fields as required Apr 11, 2019

@dsilvam dsilvam added this to the Rex Current milestone Apr 15, 2019

@dsilvam dsilvam self-assigned this Apr 15, 2019

dsilvam added a commit that referenced this issue Apr 16, 2019

dsilvam added a commit that referenced this issue Apr 16, 2019

dsilvam added a commit that referenced this issue Apr 16, 2019

dsilvam added a commit that referenced this issue Apr 16, 2019

dsilvam added a commit that referenced this issue Apr 16, 2019

#16376 test cases (#16408)
* #16376 test cases

* #16376 more test cases

* #16376 handle null map in all setProperty methods

@dsilvam dsilvam removed their assignment Apr 16, 2019

dsilvam added a commit that referenced this issue Apr 17, 2019

dsilvam added a commit that referenced this issue Apr 17, 2019

@erickgonzalez erickgonzalez self-assigned this Apr 23, 2019

@erickgonzalez

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Tested with the steps provided and it's working as it should.

@bryanboza

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

Fixed, unable to reproduce after the last changes. New enhancement created #16454

@bryanboza bryanboza moved this from REX to Done in QA Apr 24, 2019

@dsilvam dsilvam closed this Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.