Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugins] : The "com.dotcms.repackage.org.w3c.dom.Element" class is still being referenced in dependent JAR #16377

Closed
jcastro-dotcms opened this issue Apr 11, 2019 · 2 comments

Comments

@jcastro-dotcms
Copy link
Contributor

commented Apr 11, 2019

Reported via Support: https://dotcms.zendesk.com/agent/tickets/97941
Reproducible in dotCMS 5.1.1

After moving the Tika .JAR over to the ODGi context, the com.dotcms.repackage.org.w3c.dom.Element class was removed. Now, dotCMS exposes its un-repackaged version: org.w3c.dom.Element

However, the dot.core-renderer-modified-ukv_2.jar file still contained a reference to the old com.dotcms.repackage.org.w3c.dom.Element class. So, for example, when importing the com.dotcms.repackage.org.xhtmlrenderer.render.BlockBox class in an OSGi plugin, the code ends up trying to import the invalid repackaged class and throws a compilation error.

Expected behavior

The repackaged version of the class should not be referenced anymore.

Workaround

Follow the current approach with custom OSGi plugins: Provide your own versions of the .JARs that your code needs instead of relying on dotCMS code.

Desktop:

  • OS: Not relevant.
  • Browser: Not relevant.
  • Version: Not relevant.

@jcastro-dotcms jcastro-dotcms self-assigned this Apr 11, 2019

jcastro-dotcms added a commit that referenced this issue Apr 11, 2019

@jcastro-dotcms

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

PR: #16378

jgambarios added a commit that referenced this issue Apr 11, 2019

Issue 16377 invalid class referenced in dependent jar (#16378)
* #16252 format source. Introduce format checker on build. Alter style … (#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file

* Updating commit reference for src/main/enterprise

* try different location for checkstyle.xml

* Revert "#16252 format source. Introduce format checker on build. Alter style … (#16288)" (#16291)

This reverts commit 05f9082.

* Updating commit reference for src/main/enterprise

* #16377 : Referencing new repackaged version of the conflicting .JAR excluding the no-longer-valid class.

@jgambarios jgambarios added this to the Cody Current milestone Apr 11, 2019

@wezell wezell closed this Apr 23, 2019

@wezell wezell added this to Done in Enterprise Services Issues via automation Apr 23, 2019

@aotearoan

This comment has been minimized.

Copy link

commented May 6, 2019

@jcastro-dotcms when can we expect 5.1.5 to be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.