Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Untranslated language variables (message keys) in dotCMS Admin Interface #16584

Open
splotzky opened this issue May 15, 2019 · 11 comments

Comments

@splotzky
Copy link

commented May 15, 2019

Describe the bug

Some message keys in the dotCMS Admin Interface are not translated, when selecting a different admin backend language than the existing frontend languages.

Steps to reproduce the behavior:

  1. Go to demo.dotcms.com/dotAdmin
  2. Select a different language than English or Spanish and log in to the admin interface
  3. Go to Types & Tags > Content Types
  4. See untranslated language variables (message keys)
  5. Go to Types & Tags > Languages
  6. Add the language which has been selected for the current admin user
  7. Again go to Types & Tags > Content Types
  8. See all language variables translated

Expected behavior

All language variables should be translated correctly, no matter which language has been selected for the admin interface and no matter which frontend languages have been added to (or removed from) the system. The backend languages should be completely independent from the frontend languages.

Screenshots

Find attached two screenshots with highlighted message keys that have not been translated.

dotcms_content_types

dotcms_edit_contentlet

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome
  • Version: 74

Additional context

It looks as if only the Angular language variables are not translated (all messages pulled from /api/v1/languages/i18n).

Acceptance Criteria

  1. Match the design
  2. Work in all the supported browsers (don't forget IE11 and iPad)
  3. Multilanguage
  4. Unit test
@wezell

This comment has been minimized.

Copy link
Contributor

commented May 28, 2019

PR: #16616

@wezell wezell added the Needs QA label May 28, 2019

@jgambarios jgambarios added the Merged label May 28, 2019

@bryanboza bryanboza added this to REX in QA May 28, 2019

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

Tested on master and we continue showing with some variables without translation... Tested with Deutsch
SC: https://screencast.com/t/q0KeYt9U

@bryanboza bryanboza added Needs Work and removed Needs QA labels May 29, 2019

@bryanboza bryanboza moved this from REX to In Review in QA May 29, 2019

@wezell

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

@bryanboza i18n only seems to be working if you have the language set up in the backend. So, for example, if you change the login page to chinese, you do not see the chinese characters

wezell added a commit that referenced this issue May 30, 2019

wezell added a commit that referenced this issue May 30, 2019

wezell added a commit that referenced this issue May 30, 2019

jgambarios added a commit that referenced this issue May 31, 2019

@jgambarios

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

Note to QA: Cherrypicked commit 2dfd2ae in release-5.1.6, this fix is only for the release, in master will be handle in a different way.

wezell added a commit that referenced this issue May 31, 2019

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

We need to add the translations, we still showing the English keys
https://screencast.com/t/jaa8MB69

@wezell wezell closed this Jun 4, 2019

@wezell wezell reopened this Jun 4, 2019

@bryanboza bryanboza added this to Done in Release 5.1.6 Jun 4, 2019

wezell added a commit that referenced this issue Jun 5, 2019

@bryanboza bryanboza moved this from In Review to CODY in QA Jun 6, 2019

@jgambarios jgambarios removed the Needs QA label Jun 7, 2019

dsilvam added a commit that referenced this issue Jun 7, 2019

I18n (#16661)
* Update Language_zh_CN.properties (POEditor.com)

* Update Language_nl.properties (POEditor.com)

* Update Language.properties (POEditor.com)

* Update Language_fi.properties (POEditor.com)

* Update Language_fr.properties (POEditor.com)

* Update Language_de.properties (POEditor.com)

* Update Language_it.properties (POEditor.com)

* Update Language_ru.properties (POEditor.com)

* Update Language_es.properties (POEditor.com)

* #16584 unescaped langauge properties

* #16584 unescaped langauge properties
@erickgonzalez

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Still having the same issue, the language variables keys are shown until you add the language. You can see this on the login page and on the Content Types portlet.

Before Adding the Language

image

image

image

After Adding the Language

image

image

image

@erickgonzalez erickgonzalez added Needs Work and removed Merged labels Jun 7, 2019

@erickgonzalez erickgonzalez removed their assignment Jun 7, 2019

@dsilvam dsilvam modified the milestones: 060419_REX, Rex Current Jun 7, 2019

@erickgonzalez erickgonzalez self-assigned this Jun 11, 2019

@bryanboza bryanboza moved this from CODY to In Review in QA Jun 11, 2019

dsilvam added a commit that referenced this issue Jun 11, 2019

Issue 16584 i18n (#16655)
* #16613 possible fix

* #16624 fixes unescaped sql call

* #16584 fixes utils

* #16584 moving logic to the right place

* #16584 starting to add test

* #16584 moved logic to API and tests

* #16584 cleaner

* #16584 codacy

* #16584 cleanup
@dsilvam

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

PR master: #16655

@erickgonzalez

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

After the last changes, it's working as it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.