Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContentletIndexAPI.removeContentFromIndexByStructureInode does not work #16592

Closed
wezell opened this issue May 17, 2019 · 9 comments

Comments

@wezell
Copy link
Contributor

commented May 17, 2019

Found while working on #16545 - From the System > Maintenance > ReIndex screen, if you select a content type and hit the "delete then reindex" button, the method ContentletIndexAPI.removeContentFromIndexByStructureInode does not work and the content is never removed from the index.

@wezell wezell added this to the Rex Current milestone May 17, 2019

erickgonzalez added a commit that referenced this issue May 21, 2019

@erickgonzalez

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

PR: #16602

erickgonzalez added a commit that referenced this issue May 21, 2019

dsilvam added a commit that referenced this issue May 21, 2019

#16592 lowercase structure var name to remove content from index (#16602
)

* #16592 lowercase structure var name to remove content from index

* #16592 adapt test to fail with old code

* #16592 use contentTypeAPI and check NPE of the contentType, add exception

* #16592 add deprecated tag
@erickgonzalez

This comment has been minimized.

Copy link
Contributor

commented May 21, 2019

@john-thomas-dotcms on this commit e28926d a couple of methods has been marked as Deprecated

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented May 23, 2019

Fixed, tested on master // Postgres // FF

@bryanboza bryanboza added Passed QA and removed Needs QA labels May 23, 2019

@dsilvam dsilvam modified the milestones: 051419_REX, Rex Current May 28, 2019

@wezell wezell closed this May 28, 2019

@wezell wezell reopened this May 28, 2019

@wezell wezell added Needs QA and removed Needs QA labels May 28, 2019

@erickgonzalez

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

#16602 (comment) According to that comment we need to add a Timeout on this issue.

@erickgonzalez

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

PR 2 : #16640

dsilvam added a commit that referenced this issue May 29, 2019

Issue 16592 v2 (#16640)
* #16592 ignore test bc is still getting results even when it's sleep for 10 min

* #16592 add timeout to deletebyqueryaction

@dsilvam dsilvam added the Merged label May 29, 2019

dsilvam added a commit that referenced this issue May 31, 2019

#16592 lowercase structure var name to remove content from index (#16602
)

* #16592 lowercase structure var name to remove content from index

* #16592 adapt test to fail with old code

* #16592 use contentTypeAPI and check NPE of the contentType, add exception

* #16592 add deprecated tag

dsilvam added a commit that referenced this issue May 31, 2019

Issue 16592 v2 (#16640)
* #16592 ignore test bc is still getting results even when it's sleep for 10 min

* #16592 add timeout to deletebyqueryaction

@bryanboza bryanboza added this to REX in QA May 31, 2019

@dsilvam dsilvam self-assigned this May 31, 2019

@dsilvam

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

Passed Internal QA for release 5.1.6: It does reindex the content of the selected Content Type, although there's no feedback to the user that this process was completed.

@dsilvam

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

Passed Internal QA for master with the same observation in the comment above.

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented May 31, 2019

Fixed, tested on the release branch and now we are able to flush the caches sections individually

@bryanboza bryanboza added this to Done in Release 5.1.6 Jun 4, 2019

@dsilvam dsilvam modified the milestones: 060419_REX, Rex Current Jun 7, 2019

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

Fixed, tested on master // Postgres // FF

@bryanboza bryanboza added Passed QA and removed Needs QA labels Jun 10, 2019

@bryanboza bryanboza moved this from REX to Done in QA Jun 10, 2019

@wezell wezell closed this Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.