Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't close any dialog when click outside the dialog #16639

Closed
fmontes opened this issue May 29, 2019 · 2 comments

Comments

@fmontes
Copy link
Member

commented May 29, 2019

As a stakeholder, I want dialogs not show when user clicks outside them.

Is your feature request related to a problem? Please describe

We just want to make sure users don't close the dialog per accident.

Describe the solution you'd like

Users should only close the dialog on: X in the right corner, cancel button and esc key (and of course on "save" or any other action that conclude the task for what the dialog was opened)

Technical Approach

We have to dialogs dot-dialog and primeng dialog, both have a property to prevent close when click outside.

Acceptance Criteria

  1. Go over all the dialogs in the angular app and prevent to close it when click outside
  2. Work in all the supported browsers (don't forget IE11 and iPad)
  3. Multilanguage
  4. Unit test

@fmontes fmontes added this to the Fox Current milestone May 29, 2019

@fmontes fmontes self-assigned this May 30, 2019

fmontes added a commit to dotCMS/core-web that referenced this issue May 30, 2019

dotCMS/core#16638 dot-dialog closing when try to select any input text (
#1044)

dotCMS/core#16639 Don't close any dialog when click outside the dialog

fmontes added a commit to dotCMS/core-web that referenced this issue May 31, 2019

@bryanboza bryanboza added this to FOX in QA Jun 3, 2019

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

Fixed, tested on master branch // Postgres // FF & chrome

@bryanboza bryanboza added Passed QA Release and removed Needs QA labels Jun 4, 2019

@bryanboza bryanboza added this to Done in Release 5.1.6 Jun 4, 2019

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

Fixed, tested on master // postgres // FF

@bryanboza bryanboza added the Passed QA label Jun 7, 2019

@bryanboza bryanboza moved this from FOX to Done in QA Jun 7, 2019

@wezell wezell closed this Jun 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.