Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't hit complete URL Map Path on backend #16671

Open
DeanGonzalez opened this issue Jun 4, 2019 · 5 comments

Comments

Projects
6 participants
@DeanGonzalez
Copy link

commented Jun 4, 2019

Tested on latest dotcms 5.1.5 version.

When logged into the backend of dotcms, you can browse to a URLMapped page and edit it in edit mode. When you open a new tab (logged into edit mode) and try to hit a URLMapped page directly,

https://demo.dotcms.com/news/u-s-labor-department-moves-forward-on-retirement-advice-proposal

dotCMS redirects you to the detail page with no content loaded, even though same links work when browsing edit mode.

edit-mode-url-maps

@DeanGonzalez DeanGonzalez changed the title Can't hit complet URL Map Path on backend Can't hit complete URL Map Path on backend Jun 4, 2019

@DeanGonzalez DeanGonzalez added this to the Rex Current milestone Jun 4, 2019

wezell added a commit that referenced this issue Jun 4, 2019

@wezell

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2019

PR: #16672

@bryanboza bryanboza added this to Needs QA in Release 5.1.6 Jun 4, 2019

@bryanboza bryanboza moved this from Needs QA to Done in Release 5.1.6 Jun 4, 2019

dsilvam added a commit that referenced this issue Jun 4, 2019

@dsilvam dsilvam added the Merged label Jun 4, 2019

dsilvam added a commit that referenced this issue Jun 4, 2019

@bryanboza bryanboza moved this from Done to Needs QA in Release 5.1.6 Jun 4, 2019

@bryanboza

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

Fixed tested on release branch // docker // FF

@wezell

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

This does not work on authoring:

dotcms_1  | 18:41:04.363  ERROR page.PageResource - HTMLPageAssetNotFoundException on PageResource.render, parameters:  org.apache.catalina.connector.RequestFacade@4aff2281, docs/latest/user-management null:
dotcms_1  | java.lang.NullPointerException: null
dotcms_1  | 	at com.dotmarketing.cms.urlmap.URLMapAPIImpl.getContentlet(URLMapAPIImpl.java:185) ~[dotcms_5.1.6_5f12cc0.jar:?]
dotcms_1  | 	at com.dotmarketing.cms.urlmap.URLMapAPIImpl.processURLMap(URLMapAPIImpl.java:71) ~[dotcms_5.1.6_5f12cc0.jar:?]
dotcms_1  | 	at com.dotmarketing.portlets.htmlpageasset.business.render.HTMLPageAssetRenderedAPIImpl.findByURLMap(HTMLPageAssetRenderedAPIImpl.java:307) ~[dotcms_5.1.6_5f12cc0.jar:?]
dotcms_1  | 	at com.dotmarketing.portlets.htmlpageasset.business.render.HTMLPageAssetRenderedAPIImpl.getHtmlPageAsset(HTMLPageAssetRenderedAPIImpl.java:267) ~[dotcms_5.1.6_5f12cc0.jar:?]
dotcms_1  | 	at com.dotmarketing.portlets.htmlpageasset.business.render.HTMLPageAssetRenderedAPIImpl.getDefaultEditPageMode(HTMLPageAssetRenderedAPIImpl.java:212) ~[dotcms_5.1.6_5f12cc0.jar:?]
dotcms_1  | 	at com.dotcms.rest.api.v1.page.PageResource.render(PageResource.java:218) ~[dotcms_5.1.6_5f12cc0.jar:?]
dotcms_1  | 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_212]
dotcms_1  | 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_212]
dotcms_1  | 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_212]
dotcms_1  | 	at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_212]

@wezell wezell added the Needs Work label Jun 6, 2019

@wezell

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

This is broken if the content type in question does not have a Host or Folder field.

wezell added a commit that referenced this issue Jun 6, 2019

wezell added a commit that referenced this issue Jun 6, 2019

@wezell

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

pr: #16692

jgambarios added a commit that referenced this issue Jun 6, 2019

jgambarios added a commit that referenced this issue Jun 6, 2019

#16671 fixes npe (#16692)
(cherry picked from commit 67ceffb)

@dsilvam dsilvam modified the milestones: 060419_REX, Rex Current Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.