Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site name in the starter site should be demo.dotcms.com instead of starter.dotcms.com #19203

Closed
john-thomas-dotcms opened this issue Sep 1, 2020 · 9 comments
Closed

Site name in the starter site should be demo.dotcms.com instead of starter.dotcms.com #19203

john-thomas-dotcms opened this issue Sep 1, 2020 · 9 comments
Assignees
@ivorpad @erickgonzalez
Labels
Merged QA : Approved QA : Passed Internal Release : 5.3.8 Type : Defect

Comments

@john-thomas-dotcms
Copy link
Contributor

john-thomas-dotcms commented Sep 1, 2020 •
edited

Describe the bug

Currently, the Site name set in the starter site - and thus on our actual dotCMS demo site - is starter.dotcms.com. It should be demo.dotcms.com instead.

In addition, the following 2 aliases for are not needed and should be removed:

  • test.dotcms.com
  • test2.dotcms.com

To Reproduce

Steps to reproduce the behavior:

  1. Open the dotCMS demo site, or a clean starter.
  2. Open the Sites portlet (Control Panel -> Sites).
    • Result: The Site name is set to starter.dotcms.com, instead of demo.dotcms.com.

Expected behavior

The Site name should be demo.dotcms.com, and the only 2 aliases for the site should be localhost and 127.0.0.1.

Screenshots

image

Desktop (please complete the following information):

  • OS: Win 10 Pro
  • Browser: Chrome
  • Version: dotCMS 5.3.7
@erickgonzalez erickgonzalez added this to the Maintenance Sprint milestone Sep 1, 2020
@erickgonzalez
Copy link
Contributor

We need to generate a new full starter with these changes.

@wezell
Copy link
Contributor

wezell commented Sep 1, 2020

Also make sure the destinations make it to the starter.

@erickgonzalez
Copy link
Contributor

Also make sure the destinations make it to the starter.

Done
Screen Shot 2020-09-01 at 11 32 46 AM

@ivorpad ivorpad self-assigned this Sep 2, 2020
@fmontes
Copy link
Member

fmontes commented Sep 2, 2020

We need to update css that got error-deleted in the starter

image (7)

image (6)

image (5)

erickgonzalez added a commit that referenced this issue Sep 8, 2020
@erickgonzalez
#19203 update full starter
a1464dd
@erickgonzalez
Copy link
Contributor

PR for the new starter: #19231

@erickgonzalez
Copy link
Contributor

demo.dotcms.com has been updated.

fmontes pushed a commit that referenced this issue Sep 9, 2020
@erickgonzalez
#19203 Site name in the starter site should be demo.dotcms.com inst…
ad9cc0d 
…ead of `starter.dotcms.com`
@fmontes
Copy link
Member

fmontes commented Sep 9, 2020

Changing the name of the site we have problems with the containers as file in the layout because they keep pointing to the old site.

erickgonzalez added a commit that referenced this issue Sep 9, 2020
@erickgonzalez
#19203 update starter version
f052242
@erickgonzalez
Copy link
Contributor

entries at DB level were updated, a new starter has been generated 20200909

fmontes pushed a commit that referenced this issue Sep 9, 2020
@erickgonzalez
#19203 Site name in the starter site should be demo.dotcms.com inst…
f938f86 
…ead of `starter.dotcms.com`
@bryanboza
Copy link
Member

Fixed, tested on release-5.3.8 // Postgres // FF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivorpad ivorpad

@erickgonzalez erickgonzalez

Labels
Merged QA : Approved QA : Passed Internal Release : 5.3.8 Type : Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@ivorpad @fmontes @wezell @bryanboza @erickgonzalez @john-thomas-dotcms @hmoreras