Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI issues/improvements #20566

Closed
4 tasks done
fishsmith opened this issue Jun 22, 2021 · 8 comments · Fixed by #20634 or #20772
Closed
4 tasks done

UI issues/improvements #20566

fishsmith opened this issue Jun 22, 2021 · 8 comments · Fixed by #20634 or #20772

Comments

@fishsmith
Copy link
Collaborator

fishsmith commented Jun 22, 2021

  • 1) Reorder menu button needs the html rewritten. Currently it outputs a bootstrap button with two font awesome icons. This should use native dotCMS backend styles and inline svg icons. We do not load font awesome anymore.
  • 2) The add button on the content search screen has the 3 dot menu but should be using the + icon
  • 3) In the Content Search dialog "Content Type" should be first like its in the normal content search screen
  • 4) in the site browser the files/pages need to be listed most recent modified first

Reorder button screen shot
menu-reorder-btn

Add button screenshot
plus-button

Content Search Dialog
content-type-order

List order wrong on file browser
Screen Shot 2021-06-23 at 10 00 46 AM

@wezell wezell added this to the Scout Current milestone Jun 22, 2021
@alfredo-dotcms
Copy link
Contributor

alfredo-dotcms commented Jul 9, 2021

Core-web PR: https://github.com/dotCMS/core-web/pull/1702/files
Core PR: #20634

@alfredo-dotcms
Copy link
Contributor

@rweiner once merged, this https://dotcms.com/docs/latest/navtool-viewtool#ExampleAddReorderButton needs to be updated with

#if ($EDIT_MODE && $PUBLISH_HTMLPAGE_PERMISSION)

      #set($_formId="dot_form_menu_$date.date.time")
      <form class="dotcms__navbar-form" action="${directorURL}" method="post" name="${_formId}" id="${_formId}">
        <input type="hidden" name="cmd" value="orderMenu" />
        <input type="hidden" name="hostId" value="${host.identifier}" />
        <input type="hidden" name="referer" value="${VTLSERVLET_URI}" />
        <input type="hidden" name="pagePath" value="${VTLSERVLET_URI}" />
        <input type="hidden" name="startLevel" value="1" />
        <input type="hidden" name="depth" value="2" />
        <a href="javascript:document.getElementById('${_formId}').submit();" class="reorder-menu-link" data-original-title="Reorder Menu">
            <i class="arrow-up"></i> 
            <i class="arrow-down"></i> 
        </a>
      </form>

 #end

nollymar pushed a commit to dotCMS/core-web that referenced this issue Jul 16, 2021
* Add native styles to reorder menu link

* Feedback
nollymar pushed a commit that referenced this issue Jul 16, 2021
* #20566 ui-fixes-for-content-and-edit-page

* feedback
@nollymar nollymar linked a pull request Jul 16, 2021 that will close this issue
@nollymar
Copy link
Contributor

nollymar commented Aug 4, 2021

Internal QA: Needs work.
Points 1 and 2 don't seem to be fixed. However, 3 and 4 are displayed as expected.
Screen Shot 2021-08-04 at 4 47 55 PM

Screen Shot 2021-08-04 at 4 50 52 PM

Screen Shot 2021-08-04 at 4 45 15 PM

@nollymar nollymar modified the milestones: Scout Current, Maintenance Sprint Aug 4, 2021
@alfredo-dotcms
Copy link
Contributor

steps for #1

-edit a page
*this prob needs to be changed on starter (empty & full)

@nollymar
Copy link
Contributor

nollymar commented Aug 5, 2021

Point #1 is working after applying the changes explained in the comment above

alfredo-dotcms added a commit that referenced this issue Aug 5, 2021
@alfredo-dotcms
Copy link
Contributor

Core PR: https://github.com/dotCMS/core/pull/20772/files

*all icons that appear in a list view style must be replaced with a + icon

nollymar pushed a commit that referenced this issue Aug 6, 2021
@nollymar nollymar linked a pull request Aug 6, 2021 that will close this issue
@nollymar nollymar assigned nollymar and unassigned alfredo-dotcms Aug 6, 2021
@nollymar
Copy link
Contributor

nollymar commented Aug 6, 2021

Internal QA: Passed

After the latest changes, the icon displays correctly

Screen Shot 2021-08-06 at 3 07 05 PM

@bryanboza
Copy link
Member

Fixed, now we have those changes, new problem reported on card #20868

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment