Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relationships will get cleared if you Save a contentlet before they are loaded #22323

Closed
swicken-dotcms opened this issue May 31, 2022 · 12 comments
Closed

Relationships will get cleared if you Save a contentlet before they are loaded #22323

swicken-dotcms opened this issue May 31, 2022 · 12 comments
Assignees
@rjvelazco
Labels
dotCMS : Admin Tools QA : Approved QA : Passed Internal Release : 21.06.13 Included in LTS patch release 21.06.13 Release : 22.03.5 Included in LTS patch release 22.03.5 Release : 22.08 Team : Lunik Type : Defect

Comments

@swicken-dotcms
Copy link
Contributor

Describe the bug
When you open a contentlet in the backend the relationships are lazy loaded. If you submit the contentlet prior to this load completing it will save the relationships with an empty list, clearing all existing relationships.

Related ticket: https://dotcms.zendesk.com/agent/tickets/107486
Reproduced on: 22.05

To Reproduce
Steps to reproduce the behavior:

  1. Throttle your network speed to slow 3G in Chrome dev tools.
  2. Open a contentlet with a relationship.
  3. Hit Save immediately, before the relationship loads.
  4. Close and re-open the contentlet. The relationship will now be empty.

Expected behavior
The relationships should not be changed if they were not loaded when the Save button was pushed.
@fmontes
Copy link
Member

fmontes commented Jun 21, 2022

The first step is to check if this is backend or frontend, that's why I added the Cat : UI label

@rjvelazco rjvelazco self-assigned this Jun 22, 2022
fmontes pushed a commit that referenced this issue Jun 30, 2022
@rjvelazco
#22323 Relationships will get cleared if you Save a contentlet before…
972ec06 
… they are loaded (#22467)

* dev: disabled save option until relationship loads

* dev: show 'loading' relationship

* dev: lock all contentlet actions until relationships are loaded

* clean up

* clean up v2

* dev: feedback

* dev: not disabled workflow actions

* clean up v3
@erickgonzalez
Copy link
Contributor

#22467

@bryanboza
Copy link
Member

Fixed, tested on release-22.07 // Docker // FF. Unable to reproduce after the last changes.

@swicken-dotcms swicken-dotcms added LTS : Next Ticket that will be added to LTS LTS: Priority labels Aug 3, 2022
@rjvelazco
Copy link
Contributor

There is a bug on auth, after we drag & drop a relation, we never save the content.

Kapture.2022-08-05.at.12.24.01.mp4

@rjvelazco
Copy link
Contributor

PR: #22699

@rjvelazco
Copy link
Contributor

rjvelazco commented Aug 8, 2022 •
edited

Note for QA: I couldn't reproduce the issue on my local using starter, so I have to download auth assets & database -Thanks @nollymar for helping me with that-. If you need the resources I used for QA, DM.

fmontes pushed a commit that referenced this issue Aug 9, 2022
@rjvelazco
#22323 Relationships will get cleared if you Save a contentlet before…
7906dc6 
… they are loaded (#22699)

* dev: save content after modifying relations

* dev: restore ./husky/pre-commit

* dev: fix conditional

* dev: restore ./husky/pre-commit v2

* fix: MutationObserver

* ignore: test - trigger event when click select button
@fmontes
Copy link
Member

fmontes commented Aug 9, 2022 •
edited

Wait for the auth server update to do this QA

@bryanboza
Copy link
Member

Fixed, teste in the authoring server trying to reorder the relationship field and it is working as expected.

@wezell wezell closed this as completed Aug 10, 2022
dsilvam pushed a commit that referenced this issue Aug 10, 2022
@rjvelazco @dsilvam
#22323 Relationships will get cleared if you Save a contentlet before…
f44c600 
… they are loaded (#22699)

* dev: save content after modifying relations

* dev: restore ./husky/pre-commit

* dev: fix conditional

* dev: restore ./husky/pre-commit v2

* fix: MutationObserver

* ignore: test - trigger event when click select button
@erickgonzalez erickgonzalez removed Severity : Support Requested LTS : Next Ticket that will be added to LTS labels Oct 28, 2022
@erickgonzalez
Copy link
Contributor

Another customer hitting this https://dotcms.zendesk.com/agent/tickets/109320

@swicken-dotcms
Copy link
Contributor Author

Another customer hitting this: https://dotcms.zendesk.com/agent/tickets/109485

@erickgonzalez
Copy link
Contributor

erickgonzalez commented Jan 25, 2023 •
edited

this one needs the changes of #21735 so backporting as well

erickgonzalez added a commit that referenced this issue Jan 26, 2023
@erickgonzalez
#22323 include in 21.06.13
83c8395
@erickgonzalez erickgonzalez added the Release : 21.06.13 Included in LTS patch release 21.06.13 label Jan 26, 2023
erickgonzalez added a commit that referenced this issue Feb 2, 2023
@erickgonzalez
#22323 include in 22.03.5
3491958
@erickgonzalez erickgonzalez added Release : 22.03.5 Included in LTS patch release 22.03.5 and removed Next LTS Release labels Feb 2, 2023
@erickgonzalez
Copy link
Contributor

Missing change that wasn't related to this a651147#diff-651d81e1153f4e138156a2558002f2d07d4fb5c27b84fcf6d54bf944f7eb9aa6

@erickgonzalez erickgonzalez mentioned this issue Feb 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjvelazco rjvelazco

Labels
dotCMS : Admin Tools QA : Approved QA : Passed Internal Release : 21.06.13 Included in LTS patch release 21.06.13 Release : 22.03.5 Included in LTS patch release 22.03.5 Release : 22.08 Team : Lunik Type : Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fmontes @wezell @bryanboza @erickgonzalez @rjvelazco @swicken-dotcms