Upgrade to 2.3.2 to 2.5.6 fails in Oracle

[joseorsini]

Steps to reproduce.

1. Create a clean install of 2.3.2 with an Oracle database. Stop this instance once the DB is completely created.
2. Create a separate 2.5.6 build and point it to the recently created DB in step 1.
3. Start the upgrade.

Problem was detected here

https://github.com/dotCMS/dotCMS/blob/2.5.6/src/com/dotmarketing/startup/runonce/Task01055CreatePushPublishEnvironmentTable.java#L104

We call a DROP SEQUENCE PUBLISHING_QUEUE_SEC twice: on line 102 and line 104. On the second call, query was already executed so it fails.

Stacktrace:

2014-07-23 16:36:42,138 FATAL com.dotmarketing.startup.StartupTasksExecutor - Unable to execute the upgrade task : Task01055CreatePushPublishEnvironmentTable 
com.dotmarketing.exception.DotRuntimeException: ORA-02289: sequence does not exist 

at com.dotmarketing.startup.runonce.Task01055CreatePushPublishEnvironmentTable.executeUpgrade(Task01055CreatePushPublishEnvironmentTable.java:129) 
at com.dotmarketing.startup.StartupTasksExecutor.executeUpgrades(StartupTasksExecutor.java:260) 
at com.liferay.portal.servlet.MainServlet.init(MainServlet.java:117) 
at org.apache.catalina.core.StandardWrapper.loadServlet(StandardWrapper.java:1173) 
at org.apache.catalina.core.StandardWrapper.load(StandardWrapper.java:993) 
at org.apache.catalina.core.StandardContext.loadOnStartup(StandardContext.java:4187) 
at org.apache.catalina.core.StandardContext.start(StandardContext.java:4496) 
at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:791) 
at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:771) 
at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:546) 
at org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:637) 
at org.apache.catalina.startup.HostConfig.deployDescriptors(HostConfig.java:563) 
at org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:498) 
at org.apache.catalina.startup.HostConfig.start(HostConfig.java:1277) 
at org.apache.catalina.startup.HostConfig.lifecycleEvent(HostConfig.java:321) 
at org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119) 
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1053) 
at org.apache.catalina.core.StandardHost.start(StandardHost.java:785) 
at org.apache.catalina.core.ContainerBase.start(ContainerBase.java:1045) 
at org.apache.catalina.core.StandardEngine.start(StandardEngine.java:443) 
at org.apache.catalina.core.StandardService.start(StandardService.java:519) 
at org.apache.catalina.core.StandardServer.start(StandardServer.java:710) 
at org.apache.catalina.startup.Catalina.start(Catalina.java:581) 
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) 
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 
at java.lang.reflect.Method.invoke(Method.java:606) 
at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:289) 
at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:414) 
Caused by: java.sql.SQLException: ORA-02289: sequence does not exist 

at oracle.jdbc.driver.SQLStateMapping.newSQLException(SQLStateMapping.java:74) 
at oracle.jdbc.driver.DatabaseError.newSQLException(DatabaseError.java:110) 
at oracle.jdbc.driver.DatabaseError.throwSqlException(DatabaseError.java:171) 
at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:455) 
at oracle.jdbc.driver.T4CTTIoer.processError(T4CTTIoer.java:413) 
at oracle.jdbc.driver.T4C8Oall.receive(T4C8Oall.java:1030) 
at oracle.jdbc.driver.T4CStatement.doOall8(T4CStatement.java:183) 
at oracle.jdbc.driver.T4CStatement.executeForRows(T4CStatement.java:936) 
at oracle.jdbc.driver.OracleStatement.doExecuteWithTimeout(OracleStatement.java:1222) 
at oracle.jdbc.driver.OracleStatement.executeInternal(OracleStatement.java:1770) 
at oracle.jdbc.driver.OracleStatement.execute(OracleStatement.java:1739) 
at oracle.jdbc.driver.OracleStatementWrapper.execute(OracleStatementWrapper.java:298) 
at org.apache.tomcat.dbcp.dbcp.DelegatingStatement.execute(DelegatingStatement.java:264) 
at com.dotmarketing.common.db.DotConnect.executeStatement(DotConnect.java:214) 
at com.dotmarketing.startup.runonce.Task01055CreatePushPublishEnvironmentTable.recreatePublishingQueueTable(Task01055CreatePushPublishEnvironmentTable.java:104) 
at com.dotmarketing.startup.runonce.Task01055CreatePushPublishEnvironmentTable.executeUpgrade(Task01055CreatePushPublishEnvironmentTable.java:125) 
... 28 more 

[dotjorgeu]

[brentgriffin]

I believe the change was authored in August of last year but committed / merged just over two months ago. See image below: