Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captcha can be programmatically reused by passing session id #9330

Closed
wezell opened this issue Jul 6, 2016 · 2 comments
Closed

Captcha can be programmatically reused by passing session id #9330

wezell opened this issue Jul 6, 2016 · 2 comments

Comments

@wezell
Copy link
Contributor

@wezell wezell commented Jul 6, 2016

If you use a captcha protected resource like the sendEmailServlet you can pass the same captcha again and again via curl if you use the session id cookie of the original request.

Once the captcha has been checked and validated, we need to remove it from the user's session programmatically.

@wezell wezell added this to the 3.6 milestone Jul 6, 2016
@dsilvam dsilvam added the z-iter-7 label Aug 1, 2016
@oarrietadotcms oarrietadotcms self-assigned this Aug 6, 2016
@oarrietadotcms
Copy link
Contributor

@oarrietadotcms oarrietadotcms commented Aug 9, 2016

Flowdock thread

The main problem here is that captcha information will be stored in session even after get/validate the value.

Steps to Reproduce:

#set($contentFormReferer = "/path/to/thanks-page")
#set($contentUseCaptcha = true)
#submitContent("webPageContent")
  • Create another page. ie thanks-page
  • Add a widget with this code:
$session.getAttribute("simpleCaptcha")
  • Now go to captcha-page in front end, log in and fill the form and captcha. After submit you will no longer see the captcha info in the next page.

Before the fix:
screen shot 2016-08-09 at 11 09 42 am
screen shot 2016-08-09 at 11 10 07 am

@oarrietadotcms
Copy link
Contributor

@oarrietadotcms oarrietadotcms commented Aug 9, 2016

PR: #9532

@oarrietadotcms oarrietadotcms removed their assignment Aug 9, 2016
@nollymar nollymar self-assigned this Aug 11, 2016
@nollymar nollymar added Passed QA and removed Needs QA labels Aug 12, 2016
@nollymar nollymar removed their assignment Aug 12, 2016
@dsilvam dsilvam closed this Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants