Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 16333 vanity urls adding improvements #16337

Closed

Conversation

Projects
None yet
5 participants
@jcastro-dotcms
Copy link
Contributor

commented Apr 4, 2019

No description provided.

dsilvam and others added some commits Mar 26, 2019

#16252 format source. Introduce format checker on build. Alter style … (
#16288)

* #16252 format source. Introduce format checker on build. Alter style files

* #16252 remove unwanted file

* #16252 remove unwanted file
#16333 : When initializing Vanity URLs upon startup or cache flush, r…
…ead from DB instead of reading from the ES index as it may be not fully updated yet.
includeSystemHost) {
List<Contentlet> contentlets = new ArrayList<>();
final StringBuilder query = new StringBuilder();
query.append("SELECT cvi.live_inode FROM contentlet c ");
this.checkSiteLanguageVanities
(siteId, languageId, includeSystemHost);
}
} catch (final Exception e) {
} catch (final DotDataException e) {
Logger.error(this, String.format("An error occurred when retrieving Vanity URLs: siteId=[%s], " +
"languageId=[%s], includeSystemHost=[%s]", siteId, languageId, includeSystemHost), e);
} catch (final DotSecurityException e) {

This comment has been minimized.

} else {
query.append("= ? ");
}
query.append("INNER JOIN contentlet_version_info cvi ON c.identifier = cvi.identifier AND c.inode = cvi" +
includeSystemHost) {
List<Contentlet> contentlets = new ArrayList<>();
final StringBuilder query = new StringBuilder();
query.append("SELECT cvi.live_inode FROM contentlet c ");
@jdotcms

jdotcms approved these changes Apr 4, 2019

@jgambarios

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Closed as we created a branch from this changes and sent another pull request with integration tests: #16413

@jgambarios jgambarios closed this Apr 23, 2019

@jgambarios jgambarios deleted the issue-16333-vanity-urls-adding-improvements branch Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.