Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not apply omit to interface when mapper is configured #1671

Merged
merged 1 commit into from Apr 9, 2019

Conversation

Projects
None yet
2 participants
@koenpunt
Copy link
Contributor

koenpunt commented Apr 8, 2019

This PR makes sure that the omit logic is not applied when a mapper is specified for a graphql interface.

related #1670

P.s. is it possible to run the tests for a single package, instead of the whole suite? Preferably also without having to run yarn build.

@dotansimha

This comment has been minimized.

Copy link
Owner

dotansimha commented Apr 9, 2019

Looks great, thanks @koenpunt !

@dotansimha dotansimha merged commit 0819a02 into dotansimha:master Apr 9, 2019

1 check passed

ci/circleci: build Your tests passed on CircleCI!
Details

@koenpunt koenpunt deleted the koenpunt:interface-omit-fix branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.