Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapperTypeSuffix option #3451

Merged
merged 1 commit into from Feb 12, 2020
Merged

Conversation

@koenpunt
Copy link
Contributor

koenpunt commented Feb 6, 2020

this option allows you to add a suffix to all imported types to prevent name clashes with graphql types.

Followup of my comment here: #2932 (comment)

@dotansimha

This comment has been minimized.

Copy link
Owner

dotansimha commented Feb 7, 2020

Thank you @koenpunt ! This is a nice idea. Can you please add some basic unit tests for this? Thanks :)

this option allows you to add a suffix to all imported types to prevent name clashes with graphql types
@koenpunt koenpunt force-pushed the unitedwardrobe:mapperTypeSuffix branch from 6c1cd06 to c47236b Feb 7, 2020
@koenpunt

This comment has been minimized.

Copy link
Contributor Author

koenpunt commented Feb 7, 2020

Unit tests are added for the parseMapper function. Do I need to add a test for the option itself somewhere too?

@koenpunt koenpunt marked this pull request as ready for review Feb 7, 2020
@dotansimha

This comment has been minimized.

Copy link
Owner

dotansimha commented Feb 12, 2020

Looks good. Thanks @koenpunt !

@dotansimha dotansimha merged commit e7cd544 into dotansimha:master Feb 12, 2020
10 checks passed
10 checks passed
Testing on ubuntu-latest and Node 10 Testing on ubuntu-latest and Node 10
Details
Testing on ubuntu-latest and Node 12 Testing on ubuntu-latest and Node 12
Details
Testing on ubuntu-latest and Node 13 Testing on ubuntu-latest and Node 13
Details
Testing on windows-latest and Node 10 Testing on windows-latest and Node 10
Details
Testing on windows-latest and Node 12 Testing on windows-latest and Node 12
Details
Testing on windows-latest and Node 13 Testing on windows-latest and Node 13
Details
Testing on macos-latest and Node 10 Testing on macos-latest and Node 10
Details
Testing on macos-latest and Node 12 Testing on macos-latest and Node 12
Details
Testing on macos-latest and Node 13 Testing on macos-latest and Node 13
Details
Publish Canary
Details
@koenpunt koenpunt deleted the unitedwardrobe:mapperTypeSuffix branch Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.