Skip to content

added documentation for installing via puppet module#619

Closed
garethr wants to merge 3 commits into
moby:masterfrom
garethr:puppet_install_docs
Closed

added documentation for installing via puppet module#619
garethr wants to merge 3 commits into
moby:masterfrom
garethr:puppet_install_docs

Conversation

@garethr

@garethr garethr commented May 15, 2013

Copy link
Copy Markdown
Contributor

As per a conversation with @jpetazzo after posting details to the mailing list, here is some documentation for installing and managing docker using Puppet.

@kencochrane

Copy link
Copy Markdown
Contributor

Looks good thanks, I'll pull it down and test it out in a little bit, and let you know if I have any questions/issues.

Comment thread docs/sources/installation/puppet.rst Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to a note, it will stand out more.

.. note::

see https://github.com/dotcloud/docker/blob/master/docs/sources/examples/example_header.inc for an example.

@kencochrane

Copy link
Copy Markdown
Contributor

OK, just built it, it looks good, left two comments. if you can fix those two issues, I'll merge. Let me know if you have any questions.

@dhrp

dhrp commented May 16, 2013

Copy link
Copy Markdown
Contributor

Would it not make more sense to actually put this under "Use" because, pretty much everything in this guide is about how to setup containers (which is very cool btw), rather than the (mundane) how do I install Docker.

@garethr

garethr commented May 17, 2013

Copy link
Copy Markdown
Contributor Author

I've added the note and changed the highlighting and updated the pull request.

Happy to move this to use if you think that's a more suitable location?

@kencochrane

Copy link
Copy Markdown
Contributor

@garethr The changes look good, thank you.

Could you.

  1. merge master into your branch so it can resolve the pull request merge conflict.
  2. move this to the "use" section of the docs, I think @dhrp is right, it is probably better over there.
  3. merge (rebase) your commits down to one commit, for easier merging.

Thank you, sorry for all the hassle, let me know if you have any questions.

@garethr

garethr commented May 17, 2013

Copy link
Copy Markdown
Contributor Author

Closing in favour of #631 which has all the relevant changes in a single commit.

@garethr garethr closed this May 17, 2013
@garethr garethr deleted the puppet_install_docs branch May 18, 2013 07:45
rtyler pushed a commit to rtyler/docker that referenced this pull request Feb 23, 2018
Upgrade alpine to 3.7 and openjdk 8u151
thaJeztah pushed a commit to wanghuaiqing2010/moby that referenced this pull request May 8, 2026
Fix etchosts.Update to not target hosts with given hostname as prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants