added documentation for installing via puppet module#619
Conversation
|
Looks good thanks, I'll pull it down and test it out in a little bit, and let you know if I have any questions/issues. |
There was a problem hiding this comment.
Change this to a note, it will stand out more.
.. note::
see https://github.com/dotcloud/docker/blob/master/docs/sources/examples/example_header.inc for an example.
|
OK, just built it, it looks good, left two comments. if you can fix those two issues, I'll merge. Let me know if you have any questions. |
|
Would it not make more sense to actually put this under "Use" because, pretty much everything in this guide is about how to setup containers (which is very cool btw), rather than the (mundane) how do I install Docker. |
|
I've added the note and changed the highlighting and updated the pull request. Happy to move this to use if you think that's a more suitable location? |
|
@garethr The changes look good, thank you. Could you.
Thank you, sorry for all the hassle, let me know if you have any questions. |
|
Closing in favour of #631 which has all the relevant changes in a single commit. |
Upgrade alpine to 3.7 and openjdk 8u151
Fix etchosts.Update to not target hosts with given hostname as prefix
As per a conversation with @jpetazzo after posting details to the mailing list, here is some documentation for installing and managing docker using Puppet.