Fix cyclic symbolic link recursion #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonro
force-pushed
the
fix-symlink-follow
branch
2 times, most recently
from
2b06fae
to
263cc7e
Compare
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 96.98% 96.99%
=======================================
Files 32 32
Lines 2292 2295 +3
=======================================
+ Hits 2223 2226 +3
Misses 69 69
Continue to review full report at Codecov.
|
When in recursive mode: do not follow symbolic links within target directories. See dotenv-linter#326. - Add check in crate::get_file_paths to only get subdirectories if they are not symlinks. - Add test with a cyclic symlink. - Add symlink creation function for unix and windows to use in test.
sonro
force-pushed
the
fix-symlink-follow
branch
from
263cc7e
to
0eda6bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in recursive mode: do not follow symbolic links within target directories. See #326.
Add check in crate::get_file_paths to only get subdirectories if
they are not symlinks.
Add test with a cyclic symlink.
Add symlink creation function for unix and windows to use in test.
✔ Checklist: