Update dependencies and Travis CI config #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes the explicit listing of jekyll-sass-converter (included with Jekyll) and redcarpet (GitHub Pages doesn't support it anyways and uses kramdown instead) and updates dependences to the latest versions. It also improves the Travis CI config by having it first build the site and then check the generated site's links, rather than checking links in the source file `index.md`. This doesn't make that much of a difference now, though it does add checking of all the links in `_includes/default.html`, which is nice. Once this site gets multiple pages, this change will be especially useful. This patch also updates the Google Analytics script to the latest one provided from Google. This is not exactly necessary, but it has the nice side effect of working around awesome_bot accidentally picking up the 'https://ssl' and 'http://www' from the old script as links.
|
Thanks for your contribution. Having the link check happen after the site is generated from index.md is a big improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes the explicit listing of jekyll-sass-converter (included with Jekyll) and redcarpet (GitHub Pages doesn't support it anyways and uses kramdown instead) and updates dependences to the latest versions.
It also improves the Travis CI config by having it first build the site and then check the generated site's links, rather than checking links in the source file
index.md. This doesn't make that much of a difference now, though it does add checking of all the links in_includes/default.html, which is nice. Once this site gets multiple pages, this change will be especially useful.Also, the Travis CI config was broken before.
This patch also updates the Google Analytics script to the latest one provided from Google. This is not exactly necessary, but it has the nice side effect of working around awesome_bot accidentally picking up the 'https://ssl' and 'http://www' from the old script as links.