Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test dot=controller integration #119

Closed
arhimede opened this issue May 13, 2020 · 4 comments
Closed

test dot=controller integration #119

arhimede opened this issue May 13, 2020 · 4 comments
Assignees

Comments

@arhimede
Copy link
Member

starting from branch https://github.com/dotkernel/frontend/tree/issue-118
please test if is working fine

check for typos

@Calin23
Copy link
Contributor

Calin23 commented May 13, 2020

Testing Status for issue-118:

  • I don't know if is a problem from my side when I run the command "composer install" all packages are installed except "dotkernel/dot-controller" so this will return "Class 'Dot\Controller\AbstractActionController' not found"
  • runing "composer install" second time will do nothing it will return "Nothing to install or update
    "
  • I tested the installation three times same problem
  • if I run "composer update" it will install the missing package
  • dot-controller integration is working tested

Tested on:

  • macOS Catalina
  • Version 10.15.4

@bidi47
Copy link
Collaborator

bidi47 commented May 14, 2020

Testing Status for issue-118:

* I don't know if is a problem from my side when I run the command "composer install" all packages are installed except "dotkernel/dot-controller" so this will return "Class 'Dot\Controller\AbstractActionController' not found"

* runing "composer install" second time will do nothing it will return "Nothing to install or update
  "

* I tested the installation three times same problem

* if I run "composer update" it will install the missing package

* dot-controller integration is working tested

Tested on:

* macOS Catalina

* Version 10.15.4

make sure you are on branch 'issue-118'
if you simply use git clone, the installation defaults to branch '3.0' where dot-controller isn't added yet

@Calin23
Copy link
Contributor

Calin23 commented May 14, 2020

Thanks for the hint @bidi47 but the problem for installing the missing package was because of the composer.lock file , it was removed so it is not an issue anymore for installing the packages.

@bidi47
Copy link
Collaborator

bidi47 commented May 21, 2020

ok, i'll close this issue for now

@bidi47 bidi47 closed this as completed May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants