Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for ; not supported in mixin parameter lists #319 #320 #323

Merged
merged 1 commit into from Nov 27, 2013
Merged

Fixes for ; not supported in mixin parameter lists #319 #320 #323

merged 1 commit into from Nov 27, 2013

Conversation

vincentparrett
Copy link
Contributor

All previously passing tests still pass, I added a new test MixinsArgsTwoArgs_with_semi_colon_separator.

@vincentparrett
Copy link
Contributor Author

Unfortunately this doesn't fix the problem for mixin call's. I've been trying to fix that issue, but while my unit tests pass, when compiling bootstrap (3.0) I am getting a stack overflow Quoted.Evaluate with any attempts I have to fix it. Will keep looking.

@vincentparrett
Copy link
Contributor Author

I have narrowed down the last problem to this in utilities.less 👍

.clearfix {
.clearfix(); //comment out this line and I can get it to compile.
}

I have tried extracting this and the clearfix defnition from mixins.less to a unit test, but that passes.

@vincentparrett
Copy link
Contributor Author

Ok.. looks like I have hit issue #136, bummer. So close to getting bootstrap 3.0 RC1 compiling.

@saenic
Copy link

saenic commented Aug 6, 2013

Nice to finally see some active development on this.
I'm using it dotless on my IIS to directly parse .less files so I don't need the javascript. Hope you can get bootstrap 3.0 running :)

@vincentparrett
Copy link
Contributor Author

I have hit a roadblock on this... I compared dotless to less.js, and less.js explicitly deals with recursion, dot less does not. The code is different enough that I wasn't able to find the spot where it needs to happen because of the way the dotless is written. I spent way to long on this already, for now we are just using the tooling in vs.net to generate the css and have given up on dotless.

@ProductiveRage
Copy link
Contributor

I believe that the ".pull-right > .dropdown-menu();" actually refers to the ".pull-right > .dropdown-menu" selector but dotLess doesn't currently support matching mixins to multi-element selectors (it could handle a selector ".dropdown-menu" fine, but the selector being (".pull-right > dropdown-menu" is a problem for it).

Also note that the ".clearfix" issue has been addressed in the merged-in pull request #339.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants