New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Already implemented in an Open Source project #8

Closed
alhardy opened this Issue Mar 21, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@alhardy

alhardy commented Mar 21, 2017

Looks like this come from a Metrics.Net extension written for dotnet core.

My implementation written a while back looks very similar, feel as though my efforts in open sourcing will be wasted :(

Here's the Repo

@Eilon

This comment has been minimized.

Contributor

Eilon commented Mar 21, 2017

Hi @alhardy this looks like it's a coincidence because the two projects are in very similar areas, so some types and members have similar names. All the contributions to the repo here are original.

@Eilon Eilon closed this Mar 21, 2017

@glennc

This comment has been minimized.

glennc commented Mar 21, 2017

@alhardy This library is purely a way to define a set of functions that you can run to determine the health of your application, with the associated middleware and other pieces to allow it to work with ASP.NET and ASP.NET Core. AppMetrics appears to be significantly more than that.

Happy to work with you on defining what the IHealthCheckResult, IHealthCheck and IHealthCheckService interfaces should look like and discuss the ability to smoothly switch between this and your efforts.

@alhardy

This comment has been minimized.

alhardy commented Mar 21, 2017

@Eilon Not saying otherwise, just pointing out that there is already pretty much the same implementation.

@glennc Cheers, I'll try plugging in this implementation instead of mine a little down the track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment