New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling requires .NET 4.7.1 installed #909

Closed
Tarmil opened this Issue Feb 14, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@Tarmil
Member

Tarmil commented Feb 14, 2018

The problem is that although .NET 4.6.1 technically supports .NET Standard 2.0, it needs additional assemblies to do so properly. We should compile the 4.x compiler without referencing netstandard, basically the same way we used to compile it before WS 4.2. This shouldn't pose any problem, now that we check whether a type is in netstandard against a list instead of a reference, and WIG loads netstandard.dll.ref with Cecil.

@Tarmil Tarmil added the bug label Feb 14, 2018

@Tarmil Tarmil self-assigned this Feb 14, 2018

@Tarmil Tarmil added this to 4.2 in Releases Feb 14, 2018

@Tarmil

This comment has been minimized.

Member

Tarmil commented Feb 14, 2018

Ideally we should compile all extensions this way too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment