New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept string nowarn arguments #945

Closed
Tarmil opened this Issue May 9, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@Tarmil
Member

Tarmil commented May 9, 2018

See https://forums.websharper.com/topic/85114

Visual Studio 15.7 and the associated Visual F# Tools now allow passing nowarn arguments as string: --nowarn:NU1603 in addition to usual int code: --nowarn:25. We need to accept these in both wsfsc and zafircs.

As an initial hotfix we can just parse FS1234 and ignore other string codes. Later we should look into using WS1234 for our own warnings.

@Tarmil Tarmil added the bug label May 9, 2018

@Tarmil Tarmil closed this in 9dea640 May 9, 2018

@RobBarton

This comment has been minimized.

RobBarton commented May 9, 2018

Thank you, quick work!

@Jand42 Jand42 added the 4.2.11.258 label May 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment