New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit error about quoted argument position conflict #977

Closed
Jand42 opened this Issue Jul 3, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@Jand42
Member

Jand42 commented Jul 3, 2018

If SPA1 and SPA2 projects are both have project type Bundle and they both have a file with the same name used in source mapping (for example Client.fs), if one references the other, compilation can fail with Error merging dictionaries on key: {FileName = "Client.fs";....

When creating source maps for bundles, source files with the same name should be disambiguated with a postfix automatically.

Edit: This is actually not related to bundles, caused by the conflicting keys in quoted arguments stored by the WebSharper compiler. And the SPA template uses an event handler with the UI type provider, which auto-quotes its argument, even if the function it is contained in is intended for client-side only because WS does not know that. Adding a more explicit error for this.

@Jand42 Jand42 added the enhancement label Jul 3, 2018

@Jand42 Jand42 self-assigned this Jul 5, 2018

@Jand42 Jand42 changed the title from Allow same filename in multiple projects when bundling to Explicit error about quoted argument position conflict Jul 5, 2018

@Jand42 Jand42 closed this Jul 5, 2018

@Tarmil Tarmil added the 4.4.0.280 label Jul 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment