Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roslyn analyzer fails due to mismatched FSharp.Core #987

Closed
Tarmil opened this Issue Jul 10, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@Tarmil
Copy link
Member

Tarmil commented Jul 10, 2018

In order for the Roslyn analyzer to work, all of its assemblies must reference the same version of FSharp.Core, since analyzers can't include assembly redirections. So we need to separately build WebSharper.Core, WebSharper.Core.JavaScript and WebSharper.InterfaceGenerator for the same version of FSharp.Core as the compiler assemblies (aka 4.5.0.0 right now).

@Tarmil Tarmil added the bug label Jul 10, 2018

@Tarmil Tarmil self-assigned this Jul 10, 2018

@Tarmil

This comment has been minimized.

Copy link
Member Author

Tarmil commented Jul 11, 2018

Unfortunately this seems to cause issues when the analyzer tries to load macros from projects compiled against the FSharp 4.1 version of WebSharper.Core. I'm investigating this some more, not quite sure what the solution is yet.

@Tarmil Tarmil closed this in b7ac96a Jul 11, 2018

@Tarmil Tarmil added the 4.4.0.280 label Jul 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.