New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Router type with full composability #865

Merged
merged 14 commits into from Dec 15, 2017

Conversation

Projects
None yet
1 participant
@Jand42
Member

Jand42 commented Dec 15, 2017

Previously described at dotnet-websharper/ui#142, adding a new Router type with full composability, that also works on both client and the server.

Compatibility with the old WebSharper.Sitelets.Router type is kept mostly through the WebSharper.Sitelets.IRouter interface, that the new Router implements, and Sitelet values use.

Server-side Infer is optimized to use StringBuilders directly as old Sitelets.Infer was, improving on performance in two ways:

  • no backtracking with better handling of union types
  • errors are not tracked, unless using InferWithCustomErrors and that does a normal Infer first, and only then parsing again with ignoring but reporting method, query and body errors as before.
    ilsp
    WebSharper.UI contains only a few additional utilities for installing a Router for client-side routing.

@Jand42 Jand42 merged commit a4ce749 into master Dec 15, 2017

Jand42 added a commit that referenced this pull request Dec 18, 2017

Jand42 added a commit that referenced this pull request Dec 19, 2017

Jand42 added a commit that referenced this pull request Dec 20, 2017

Jand42 added a commit that referenced this pull request Dec 20, 2017

@Jand42 Jand42 added the 4.1.0.171 label Dec 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment