New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in Autocomplete. #8

Merged
merged 2 commits into from Dec 16, 2015

Conversation

Projects
None yet
2 participants
@juselius
Contributor

juselius commented Dec 15, 2015

In the original version, [<Name "source">] was used for each type of completer. This resulted in WebSharper generating four distinct target values (i.e. source, source1, source2, source3), which caused autocomplete to fail for all but the first completer (simple array). Furthermore, autocomplete() in JQueryUI.js expects a callback with two arguments, but the translated (F#) callback expects an array with two elements. This is fixed by bridging the call to the F# function.

juselius added some commits Dec 15, 2015

Fix bug in Autocomplete.
In the original version, [<Name "source">] for each type of completer.
This resuled in WebSharper generating four distinct target values (i.e.
source, source1, source2, source3), which caused autocomplete to fail for all
but the first completer (simple array). Furthermore, autocomplete() in
JQueryUI.js expects a callback with two arguments, but the translated (F#)
callback expects an array with two elements. This is fixed by bridging the
call to the F# function.

Tarmil added a commit that referenced this pull request Dec 16, 2015

Merge pull request #8 from juselius/master
Fix bug in Autocomplete.

@Tarmil Tarmil merged commit 6518ad1 into dotnet-websharper:master Dec 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment