Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Blazor built-in components down in ToC #19917

Closed
wants to merge 1 commit into from
Closed

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Sep 17, 2020

Scott ...

I'm still not getting the best behavior out of the ToC with the built-in component links embedded near the top of the Components node. The problem is still that when a reader selects one they end up with a highlighted ToC entry of the component in the Built-in components list and not the highlighted ToC entry of the topic where that link sent them.

I think what's happening is that it's matching the first href/uid (URL) it comes to down the ToC. I think that by moving the whole node to the bottom of the Blazor ToC that it will start matching, thus highlighting, the topic where the component is described.

If you think I'm right, let's give this PR shot. If you have a better plan to achieve the behavior I seek, I'm all 馃憘馃憘馃憘馃憘馃憘.

UPDATE: What about setting topicHref?

If topicHref is set for this TOC Item, it will be considered as the href of the expanded TOC Item.

... that sounds good if I'm interpreting it correctly as matching my goal (i.e., set it to the landing topic). 馃 Depends on what they mean by "it" ... pronouns ... they're great ... until they aren't. 馃槃

@scottaddie
Copy link
Member

@guardrex topicHref sounds promising. I recommend trying that.

@guardrex guardrex closed this Sep 18, 2020
@guardrex guardrex deleted the guardrex-patch-1 branch September 18, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants