New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC Diagnoser should not include allocations done by Setup method #186

Closed
Bobris opened this Issue May 23, 2016 · 3 comments

Comments

Projects
None yet
4 participants
@Bobris

Bobris commented May 23, 2016

See subj.

@mattwarren

This comment has been minimized.

Show comment
Hide comment
@mattwarren

mattwarren May 23, 2016

Contributor

Hmm, yeah that's a good point, I'll take a look (also see #133)

Contributor

mattwarren commented May 23, 2016

Hmm, yeah that's a good point, I'll take a look (also see #133)

@mattwarren mattwarren self-assigned this May 23, 2016

@Bobris

This comment has been minimized.

Show comment
Hide comment
@Bobris

Bobris May 23, 2016

I read whole #133 before submitting this one, but because I don't have problem with unstable results and it didn't mentioned Setup method, I though should be good to separate these.

Bobris commented May 23, 2016

I read whole #133 before submitting this one, but because I don't have problem with unstable results and it didn't mentioned Setup method, I though should be good to separate these.

@mattwarren

This comment has been minimized.

Show comment
Hide comment
@mattwarren

mattwarren May 23, 2016

Contributor

I read whole #133 before submitting this one, but because I don't have problem with unstable results and it didn't mentioned Setup method, I though should be good to separate these.

Yeah that's absolutely fine, I wasn't saying it was a dupe, it was more a note to myself to fix that #133 at the same time.

Thanks for reporting this BTW, I didn't even consider the effect of [Setup] along with the MemoryDiagnoser.

Contributor

mattwarren commented May 23, 2016

I read whole #133 before submitting this one, but because I don't have problem with unstable results and it didn't mentioned Setup method, I though should be good to separate these.

Yeah that's absolutely fine, I wasn't saying it was a dupe, it was more a note to myself to fix that #133 at the same time.

Thanks for reporting this BTW, I didn't even consider the effect of [Setup] along with the MemoryDiagnoser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment