New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HardwareCounter.InstructionRetired failing with ArgumentNullException. Build 82 #412
Comments
I can confirm that still fails on build 10.3.86 ... I am giving a course on performance tomorrow and using BenchmarkDotNet throughout it. It would be awesome to showcase the ability to measure low level CPU behavior. Do you think it could be solved by then? @AndreyAkinshin @adamsitnik @mattwarren |
@redknightlois sure, starting investigation right now |
@redknightlois I can reproduce it, it's my bug in the configuration. I'll work on a fix now, but in the meantime you can workaround it: Please comment the per type config: Job.Default
.With(Platform.X64)
.With(Jit.RyuJit)
.WithHardwareCounters(HardwareCounter.InstructionRetired) @AndreyAkinshin I am going to make the counters part of IConfig, not Job. btw: sample results: BenchmarkDotNet=v0.10.3.20170407-develop, OS=Windows 10.0.14393
Processor=Intel(R) Core(TM) i7-6600U CPU 2.60GHz, ProcessorCount=4
Frequency=2742191 Hz, Resolution=364.6719 ns, Timer=TSC
[Host] : Clr 4.0.30319.42000, 64bit RyuJIT-v4.6.1637.0
Job-HNGBTQ : Clr 4.0.30319.42000, 64bit RyuJIT-v4.6.1637.0
HardwareCounters=InstructionRetired Jit=RyuJit Platform=X64
|
@redknightlois fixed, you don't need the workaround anymore. The CI version build number is 0.10.3.87 Good luck with your course tomorrow! |
Thanks!!! Confirmed working! |
@adamsitnik, another awesome bugfix, thanks!
It's a very good idea! |
I tried to run: https://gist.github.com/redknightlois/7341ae1f13924a1baef49df9415f40af
And got this exception.
The text was updated successfully, but these errors were encountered: