Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
No namespace in export filenames can lead to data loss #529
Yesterday I added benchmarks to NodaTime for a type, NodaTime.TimeZones.StandardDaylightAlternatingMap. I put the benchmarks in the NodaTime.Benchmarks.NodaTimeTests.TimeZones namespace.
As it happens, I already had some benchmarks for that type, in the NodaTime.Benchmarks.NodaTimeTests namespace. When I looked at the results of my overnight run, only the new tests existed. That's because the JSON file that's generated only includes the short type name, with no namespace.
That's probably great for cases when you're looking at results by hand and don't want long filenames, but in my case I'd rather have long filenames (which are being consumed automatically anyway) and no loss of data.
Perhaps this should be an exporter option?
referenced this issue
Aug 19, 2017
I dug around the code and this is what I discovered about exported files' naming conventions:
This change would cause a small side effect to the actual output data by making the
I can start fixing this, if these changes look good to you!
@adamsitnik I think you're right, it should work nicely without any side effects if the
This then leaves only one more question about the filename handling inside the
That custom title is apparently also being used as the filename when exporting, so should I include some kind of check like this inside