New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build error on Appveyor with recent changes. #530

Closed
Ky7m opened this Issue Aug 20, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@Ky7m
Collaborator

Ky7m commented Aug 20, 2017

After recent changes there is build issue on Windows platfrom:

========================================
FastTests
========================================
Executing task: FastTests
Test run for C:\projects\benchmarkdotnet\tests\BenchmarkDotNet.Tests\bin\Release\netcoreapp1.1\BenchmarkDotNet.Tests.dll(.NETCoreApp,Version=v1.1)
Microsoft (R) Test Execution Command Line Tool Version 15.0.0.0
Copyright (c) Microsoft Corporation.  All rights reserved.
Starting test execution, please wait...
Illegal characters in path.
Parameter name: path

It is also reproducible on local environment with the latest changes:

dotnet.exe test ".\tests\BenchmarkDotNet.Tests\BenchmarkDotNet.Tests.csproj" --configuration Release --no-build

If I remove --no-build argument error doesn't appear. --no-build flag means that do not build the test project prior to running it. It was added as optimization to save time because we build entire solution on previous step.
Without --no-build everything works as expected:

dotnet.exe test ".\tests\BenchmarkDotNet.Tests\BenchmarkDotNet.Tests.csproj" --configuration Release

@adamsitnik what do you think is it a root of build issue, are there some structures/configuration changes that lead to this strange behavior?

Are you ok to remove --no-build argument? If yes, I will send a new PR to fix build on AppVeyor // cc: @AndreyAkinshin

@adamsitnik

This comment has been minimized.

Show comment
Hide comment
@adamsitnik

adamsitnik Aug 20, 2017

Member

@Ky7m big thanks for spotting this!

I am quite surprised with this error: my changes went green and after this we started getting red ones. I am suprised because we get a timeout on AppVeyour:

Build execution time has reached the maximum allowed time for your plan (60 minutes).

I would expect the build to fail fast with this error (Illegal characters in path).

What I changed:
I added two new projects and set their build output to another project's resources (to embed one exe in another). It should not be a problem.

I would be very happy to accept the PR that removes --no-build if it helps. It seems to me like an AppVeyor or dotnet cli bug.

Member

adamsitnik commented Aug 20, 2017

@Ky7m big thanks for spotting this!

I am quite surprised with this error: my changes went green and after this we started getting red ones. I am suprised because we get a timeout on AppVeyour:

Build execution time has reached the maximum allowed time for your plan (60 minutes).

I would expect the build to fail fast with this error (Illegal characters in path).

What I changed:
I added two new projects and set their build output to another project's resources (to embed one exe in another). It should not be a problem.

I would be very happy to accept the PR that removes --no-build if it helps. It seems to me like an AppVeyor or dotnet cli bug.

@Ky7m

This comment has been minimized.

Show comment
Hide comment
@Ky7m

Ky7m Aug 20, 2017

Collaborator

@adamsitnik, PR is ready.

Collaborator

Ky7m commented Aug 20, 2017

@adamsitnik, PR is ready.

@AndreyAkinshin AndreyAkinshin added this to the v0.10.10 milestone Aug 21, 2017

alegarciamina added a commit to alegarciamina/safe-browsing that referenced this issue Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment