New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test "CanDisassembleAllMethodCalls" fails on Ubuntu #555

Closed
Ky7m opened this Issue Sep 25, 2017 · 1 comment

Comments

Projects
None yet
3 participants
@Ky7m
Collaborator

Ky7m commented Sep 25, 2017

Test CanDisassembleAllMethodCalls with (jit: RyuJit, platform: X64, runtime: Core) parameters fails on Ubuntu

Runtime Environment:
 OS Name:     ubuntu
 OS Version:  14.04
 OS Platform: Linux
 RID:         ubuntu.14.04-x64

with following stacktrace:

System.InvalidOperationException : Sequence contains no elements
Stack Trace:
at System.Linq.Enumerable.Single[TSource](IEnumerable`1 source)
at BenchmarkDotNet.IntegrationTests.DisassemblyDiagnoserTests.<CanDisassembleAllMethodCalls>g__AssertDisassembled3_0(IDisassemblyDiagnoser diagnoser, String calledMethodName)
at BenchmarkDotNet.IntegrationTests.DisassemblyDiagnoserTests.CanDisassembleAllMethodCalls(Jit jit, Platform platform, Runtime runtime)

More details:
https://travis-ci.org/Ky7m/BenchmarkDotNet/jobs/279612017#L5287

Issue is connected to this code:

Assert.True(diagnoser.Results.Single().Value
.Methods.Any(method => method.Name.Contains(calledMethodName) && method.Maps.Any(map => map.Instructions.Any())),
$"{calledMethodName} is missing");

but I am not sure about root of the problem. Is it possible to have empty Results collection?

@adamsitnik

This comment has been minimized.

Show comment
Hide comment
@adamsitnik

adamsitnik Sep 26, 2017

Member

hello @Ky7m

it fails because the disassembler does not support non-Windows OS. So the fix would be to make the test run only on Windows

Member

adamsitnik commented Sep 26, 2017

hello @Ky7m

it fails because the disassembler does not support non-Windows OS. So the fix would be to make the test run only on Windows

@adamsitnik adamsitnik self-assigned this Sep 26, 2017

@AndreyAkinshin AndreyAkinshin added this to the v0.10.10 milestone Sep 26, 2017

alinasmirnova added a commit to alinasmirnova/BenchmarkDotNet that referenced this issue Sep 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment