Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --list #905

Closed
adamsitnik opened this issue Oct 10, 2018 · 5 comments
Closed

Implement --list #905

adamsitnik opened this issue Oct 10, 2018 · 5 comments
Milestone

Comments

@adamsitnik
Copy link
Member

Implement --list which is going to print all of the available full benchmark names that can be used for filtering.

@WojciechNagorski
Copy link
Contributor

I would like to try to do it next week.

@jorive
Copy link
Member

jorive commented Oct 12, 2018

Can the display be a tree structure like, using namespace -> type -> method? In CoreFx there are more that thousand micro benchmarks, and a single/flat list would not be very helpful.
For example,
Instead of displaying:

System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseEndianness
System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseUsingNtoH
System.Buffers.Binary.Tests.BinaryReadAndWriteTests.ReadStructAndReverseBE
System.Buffers.Binary.Tests.BinaryReadAndWriteTests.ReadStructAndReverseLE
System.Buffers.Binary.Tests.BinaryReadAndWriteTests.ReadStructFieldByFieldBE
System.Buffers.Binary.Tests.BinaryReadAndWriteTests.ReadStructFieldByFieldLE
System.Buffers.Binary.Tests.BinaryReadAndWriteTests.ReadStructFieldByFieldUsingBitConverterBE
System.Buffers.Binary.Tests.BinaryReadAndWriteTests.ReadStructFieldByFieldUsingBitConverterLE

You could display (option 1):

System.Buffers.Binary.Tests.BinaryReadAndWriteTests
  MeasureReverseEndianness
  MeasureReverseUsingNtoH
  ReadStructAndReverseBE
  ReadStructAndReverseLE
  ReadStructFieldByFieldBE
  ReadStructFieldByFieldLE
  ReadStructFieldByFieldUsingBitConverterBE
  ReadStructFieldByFieldUsingBitConverterLE

Or display names split to the namespace level as nodes can have more tests (option 2):

System
  Buffers
    Binary
      Tests
        BinaryReadAndWriteTests
          MeasureReverseEndianness
          MeasureReverseUsingNtoH
          ReadStructAndReverseBE
          ReadStructAndReverseLE
          ReadStructFieldByFieldBE
          ReadStructFieldByFieldLE
          ReadStructFieldByFieldUsingBitConverterBE
          ReadStructFieldByFieldUsingBitConverterLE

@adamsitnik
Copy link
Member Author

I like @jorive idea!

@jorive
Copy link
Member

jorive commented Oct 12, 2018

You could have an option like this: --list-benchmarks:[flat|tree]

@WojciechNagorski
Copy link
Contributor

WojciechNagorski commented Oct 12, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants