Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement `--list` #905

Closed
adamsitnik opened this issue Oct 10, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@adamsitnik
Copy link
Member

commented Oct 10, 2018

Implement --list which is going to print all of the available full benchmark names that can be used for filtering.

@wojtpl2

This comment has been minimized.

Copy link
Collaborator

commented Oct 12, 2018

I would like to try to do it next week.

@jorive

This comment has been minimized.

Copy link
Member

commented Oct 12, 2018

Can the display be a tree structure like, using namespace -> type -> method? In CoreFx there are more that thousand micro benchmarks, and a single/flat list would not be very helpful.
For example,
Instead of displaying:

System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseEndianness
System.Buffers.Binary.Tests.BinaryReadAndWriteTests.MeasureReverseUsingNtoH
System.Buffers.Binary.Tests.BinaryReadAndWriteTests.ReadStructAndReverseBE
System.Buffers.Binary.Tests.BinaryReadAndWriteTests.ReadStructAndReverseLE
System.Buffers.Binary.Tests.BinaryReadAndWriteTests.ReadStructFieldByFieldBE
System.Buffers.Binary.Tests.BinaryReadAndWriteTests.ReadStructFieldByFieldLE
System.Buffers.Binary.Tests.BinaryReadAndWriteTests.ReadStructFieldByFieldUsingBitConverterBE
System.Buffers.Binary.Tests.BinaryReadAndWriteTests.ReadStructFieldByFieldUsingBitConverterLE

You could display (option 1):

System.Buffers.Binary.Tests.BinaryReadAndWriteTests
  MeasureReverseEndianness
  MeasureReverseUsingNtoH
  ReadStructAndReverseBE
  ReadStructAndReverseLE
  ReadStructFieldByFieldBE
  ReadStructFieldByFieldLE
  ReadStructFieldByFieldUsingBitConverterBE
  ReadStructFieldByFieldUsingBitConverterLE

Or display names split to the namespace level as nodes can have more tests (option 2):

System
  Buffers
    Binary
      Tests
        BinaryReadAndWriteTests
          MeasureReverseEndianness
          MeasureReverseUsingNtoH
          ReadStructAndReverseBE
          ReadStructAndReverseLE
          ReadStructFieldByFieldBE
          ReadStructFieldByFieldLE
          ReadStructFieldByFieldUsingBitConverterBE
          ReadStructFieldByFieldUsingBitConverterLE
@adamsitnik

This comment has been minimized.

Copy link
Member Author

commented Oct 12, 2018

I like @jorive idea!

@jorive

This comment has been minimized.

Copy link
Member

commented Oct 12, 2018

You could have an option like this: --list-benchmarks:[flat|tree]

@wojtpl2

This comment has been minimized.

Copy link
Collaborator

commented Oct 12, 2018

@AndreyAkinshin AndreyAkinshin added this to the v0.11.2 milestone Oct 16, 2018

Ky7m added a commit to Ky7m/BenchmarkDotNet that referenced this issue Oct 16, 2018

Merge branch 'master' into azure-pipelines
* master:
  Implement `--list` - fixes dotnet#905 (dotnet#914)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.