New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BenchmarkDotNet.Mathematics.StatisticalTesting.MannWhitneyTest.PValueForSmallN(int n, int m, double u) #948

Closed
ArheusLis opened this Issue Nov 7, 2018 · 5 comments

Comments

Projects
None yet
3 participants
@ArheusLis

ArheusLis commented Nov 7, 2018

If I use only ClrJob & CoreJob - all fine.
But then I tried MonoJob or CoreRtJob after all test pass I see: System.IndexOutOfRangeException: 'Index was outside the bounds of the array.' in BenchmarkDotNet.Mathematics.StatisticalTesting.MannWhitneyTest.PValueForSmallN(int n, int m, double u) .
May be I'm using something wrong?

Bechmark is simple:
[Benchmark]
public void ERange()
{
for (int i = 0; i < N; i++)
{
Enumerable.Range(0, N);
}
}

and
[CoreRtJob][CoreJob] [ClrJob][MonoJob("mono", @"C:\Program Files\Mono\bin\mono.exe")]

@ArheusLis

This comment has been minimized.

ArheusLis commented Nov 8, 2018

На 0.11 проблема не воспроизводится.
На 0.12 - регулярно.

@wojtpl2

This comment has been minimized.

Collaborator

wojtpl2 commented Nov 9, 2018

I can't reproduce this error. What value of N do you use? I checked 1, 10, 1000 and I didn't get this error.

I checked that MannWhitneyTest.cs file haven't been changing since 28/9/2018.

I created branche issue_948 in my fork https://github.com/wojtpl2/BenchmarkDotNet/tree/issue_948 and I added your simple benchmark wojtpl2@cbc0713. Can you check if I'm doing everything right?

@wojtpl2

This comment has been minimized.

Collaborator

wojtpl2 commented Nov 9, 2018

Problem is in 05cc8d1 commit. I'll try to understend it and fix. It was added in 0.11.2.

@wojtpl2

This comment has been minimized.

Collaborator

wojtpl2 commented Nov 9, 2018

I have stack trace from debug:

   at BenchmarkDotNet.Mathematics.StatisticalTesting.MannWhitneyTest.PValueForSmallN(Int32 n, Int32 m, Double u) in C:\Work\BenchmarkDotNet\src\BenchmarkDotNet\Mathematics\StatisticalTesting\MannWhitneyTest.cs:line 26

wojtpl2 added a commit to wojtpl2/BenchmarkDotNet that referenced this issue Nov 9, 2018

@wojtpl2

This comment has been minimized.

Collaborator

wojtpl2 commented Nov 9, 2018

I've created PR #951 with failing test.

AndreyAkinshin added a commit that referenced this issue Nov 14, 2018

@AndreyAkinshin AndreyAkinshin self-assigned this Nov 14, 2018

@AndreyAkinshin AndreyAkinshin added this to the v0.11.3 milestone Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment