dotnet / BenchmarkDotNet Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of --profiler NativeMemory command line argument #1208
Support of --profiler NativeMemory command line argument #1208
Conversation
I am not sure. On the one hand, it's using EtwProfiler API to get the data. On the other, it reports the metrics and doesn't print a file path to the trace file so it's transparent to the end-user. Does the trace file contain enough information to track the type names? Or something very useful in general? If so, you can rename it to Profiler but also print the paths to the trace files. |
I'm going to check it. If it is possible to trace the type names, I will change the name to Profiler. |
Great, please let me know once you got it so we can merge this PR and release 0.11.6 |
@adamsitnik I know what I have to do to track the type names, using PerfView. It requires small changes in |
Yes! I think that it would be nice if users could find out not only the native allocation size but also what was allocated if they open the trace file in a profiler. |
@wojtpl2 please let me know when this is ready to test ;) |
Not yet but today morning it will be. I just need test it and describe how it works. |
@adamsitnik I have a question when you want to release a new version of BDN? I would like to know how much time I have to write my blog about this topic. |
My plan is to finish #1188 on Monday and then we should be able to release a new version by the end of next week |
In this PR I support command line argument:
@adamsitnik I wonder if
NativeMemoryDiagnoser
shouldn't be namedNativeMemoryProfiler
?We have
MemoryDiagnoser
but there is alsoEtwProfiler
andConcurrencyVisualizerProfiler
.