Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plots with a double dash (--) in the names (#1183) #1212

Merged
merged 5 commits into from Aug 3, 2019

Conversation

@marcnet80
Copy link
Contributor

marcnet80 commented Jul 24, 2019

@dnfclas

This comment has been minimized.

Copy link

dnfclas commented Jul 24, 2019

CLA assistant check
All CLA requirements met.

@AndreyAkinshin

This comment has been minimized.

Copy link
Member

AndreyAkinshin commented Jul 26, 2019

@marcnet80 I think, it will be better to use - in this case instead of -Default-. When we don't have any parameters, Default doesn't make any sense here, but it increases the length of the file name.

@AndreyAkinshin AndreyAkinshin self-requested a review Jul 26, 2019
marcnet80 added 3 commits Jul 26, 2019
remove "Default"
fix assignment operations
replace assignments operator
@AndreyAkinshin AndreyAkinshin self-requested a review Aug 3, 2019
@AndreyAkinshin AndreyAkinshin added this to the v0.11.6 milestone Aug 3, 2019
@AndreyAkinshin AndreyAkinshin merged commit 5d7c789 into dotnet:master Aug 3, 2019
4 checks passed
4 checks passed
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.