change the runtimes API #1277
Merged
change the runtimes API #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docs/_changelog/header/v0.11.6.md
Outdated
| [TargetFrameworkJob(TargetFrameworkMoniker.Mono)] | ||
| [TargetFrameworkJob(TargetFrameworkMoniker.NetCoreApp21)] | ||
| [TargetFrameworkJob(TargetFrameworkMoniker.NetCoreApp30)] | ||
| [SimpleJob(runtimeMoniker: RuntimeMoniker.Net48)] |
There was a problem hiding this comment.
Don't like the runtimeMoniker prefix. Could we introduce a few additional SimpleJobAttribute ctor overloads with the RuntimeMoniker as the first ctor argument?
| [Obsolete("Please use SimpleJobAttribute instead.", false)] | ||
| public class ClrJobAttribute : JobConfigBaseAttribute | ||
| { | ||
| public ClrJobAttribute() : base(Job.Default.With(ClrRuntime.GetCurrentVersion())) |
|
|
||
| namespace BenchmarkDotNet.Attributes | ||
| { | ||
| [Obsolete("Please use DryJobAttribute instead. Use the ctor that requires RuntimeMoniker argument.", false)] |
There was a problem hiding this comment.
Instead of "Use the ctor that requires RuntimeMoniker argument", it will be better to write a code example that can be copy-pasted.
|
@adamsitnik in general, it looks very good, thanks! I left just a few minor (but important) comments. |
|
@AndreyAkinshin thanks for the review! I've pushed the fixes. Please let me know if there is any blocker for 0.11.6 from my side |
AndreyAkinshin
approved these changes
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndreyAkinshin this fixes the things we have discussed yesterday at Dotnetos
When it comes to:
I made it a warning as we talked but I've not introduced the concept of
InvalidConfig.What I did instead is to call the
GetCurrentVersionmethod for every runtime.If the
host runtime == job runtime, then it's going to work fine (99% of the cases). If the runtimes are different: for example running as Full .NET Framework and trying to use[CoreJob]attribute, thenGetCurrentVersionis going to throw:BenchmarkDotNet/src/BenchmarkDotNet/Environments/Runtimes/CoreRuntime.cs
Line 44 in 2ba3033