Jump to conversation
Unresolved conversations (0)
Nice work!

Nice work!

All of your conversations have been resolved.

Resolved conversations (2)
@adamsitnik adamsitnik Oct 18, 2022
We should avoid having disposable static instances, please just pass the instance to the right method.
Outdated
...arkDotNet/Running/BenchmarkRunnerClean.cs
timcassell
@adamsitnik adamsitnik Oct 18, 2022
I would prefer to avoid adding any OS-specific sys-calls to this type (`BenchmarkRunner` is already way too big and too ugly ;) ). Instead, we could create a new `IDisposable` helper type that would do the following: - Do nothing on non-Windows OS-es - On Windows: - read console handle in the `ctor` and sign up for the Ctrl+C just once - unregister from the event in Dispose - expose two methods: `ResetProgress` and `SetProgress` and use the helper from runner
Outdated
...arkDotNet/Running/BenchmarkRunnerClean.cs
timcassell