Allow filters to filter out every benchmark from a type (Fixes #2860) #2879
+55
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dotnet-policy-service agree |
Collaborator
|
Can you please add a test for the new behavior? |
Contributor
Author
|
Done! The name is kind of long though, let me know if I should change it. |
timcassell
reviewed
Nov 29, 2025
tests/BenchmarkDotNet.Tests/Running/RunningEmptyBenchmarkTests.cs
Outdated
Show resolved
Hide resolved
timcassell
approved these changes
Nov 29, 2025
Collaborator
|
Thanks @User0332 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2860
Previous Behavior
Running
BenchmarkRunner.Run(Assembly, config)with a filter that eliminated all benchmarks from any one type within the specified assembly would errorNo [Benchmark] attribute found on 'MyTypeWithFilteredOutCases' benchmark caseand not run any benchmarks within the assembly.New Behavior
Even if all the benchmarks from one type are completely filtered out,
BenchmarkRunner.Run(Assembly, config)will still run the selected benchmarks from all other types within the assembly.If the filter happens to eliminate all benchmarks across all types within the assembly,
There are no benchmarks foundwill be printed and zero benchmarks will run.