chore: Add PolySharp dev dependency and cleanup #if-#endif preprocessor #2881
+25
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks. I think PolySharp also generates DynamicDependencyAttribute, so we should be able to remove the ifdefs around it also, right? |
Contributor
Author
|
I've add commit that remove |
timcassell
approved these changes
Nov 29, 2025
Collaborator
timcassell
left a comment
timcassell
left a comment
There was a problem hiding this comment.
Thanks, I was just waiting for the tests to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add PolySharp dev dependency.
And cleanup #if-#endif preprocessor that are used on
SupportedOSPlatform/SupportedOSPlatformGuard.The purpose of adding PolySharp dependency if followings.
netstandard2.0tfm (e.g. init-only properties/required field)