Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about antivirus software after benchmark failure #512

Merged
merged 4 commits into from Aug 1, 2017
Merged

Warning about antivirus software after benchmark failure #512

merged 4 commits into from Aug 1, 2017

Conversation

lukasz-pyrzyk
Copy link
Contributor

According to the #364

In case of invalid error code, analyzer prints warning about installed antivirus software and InProcessToolchain.

Tested with Symantec and Windows Defender.

sb.AppendLine();

foreach (var av in avProducts)
sb.AppendLine($"\t - {av}");

This comment was marked as spam.

This comment was marked as spam.

@AndreyAkinshin
Copy link
Member

It looks much better now.
Could you also add a note about it in docs/guide/FAQ.md?

@lukasz-pyrzyk
Copy link
Contributor Author

Changed to spaces and added a FAQ note. What do you think?

@AndreyAkinshin AndreyAkinshin added this to the v0.10.10 milestone Aug 1, 2017
@AndreyAkinshin AndreyAkinshin merged commit 9ae365a into dotnet:master Aug 1, 2017
@AndreyAkinshin
Copy link
Member

Great, thanks!

alinasmirnova pushed a commit to alinasmirnova/BenchmarkDotNet that referenced this pull request Sep 22, 2018
* dotnet#364 - Detecting antivirus software

* dotnet#364 - Printing information about AV only after benchmark failure

* dotnet#364 - spaces instead of tab

* dotnet#364 - FAQ hint about EnvironmentAnalyser and antivirus detection
@mbjasonayer
Copy link

My AV is controlled by my work's IT so disabling AV is out for me. Does anyone have a work around for this issue? I tried a suggestion from another thread about running Command Prompt with Administrator rights from the executable's location, but that did not help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants