New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#495 - Unit test for reading attributes from the base class #514

Merged
merged 2 commits into from Aug 2, 2017

Conversation

Projects
None yet
4 participants
@lukasz-pyrzyk
Collaborator

lukasz-pyrzyk commented Aug 2, 2017

#495 was fixed by @ipjohnson in 557246d by using GetCustomAttributes instead of ReflectionExtensions::HasAttribute. Version v0.10.9 has this fix.

To be sure, I've added a unit test for expected behaviour

@adamsitnik

Big thanks for the tests, please update the assertions

@adamsitnik adamsitnik merged commit 74b41ef into dotnet:master Aug 2, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@AndreyAkinshin AndreyAkinshin added this to the v0.10.10 milestone Aug 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment