New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding validator for setup cleanup attributes #525

Merged
merged 1 commit into from Aug 13, 2017

Conversation

Projects
None yet
4 participants
@ipjohnson
Contributor

ipjohnson commented Aug 11, 2017

this is to address issue #511 adds a validator for setup cleanup attributes as well as prefers targeted setup and cleanup methods over non targeted.

@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Aug 11, 2017

@ipjohnson,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

dnfclas commented Aug 11, 2017

@ipjohnson,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@adamsitnik

This comment has been minimized.

Show comment
Hide comment
@adamsitnik

adamsitnik Aug 13, 2017

Member

@ipjohnson thanks a lot!

Member

adamsitnik commented Aug 13, 2017

@ipjohnson thanks a lot!

@adamsitnik adamsitnik merged commit 424723f into dotnet:master Aug 13, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@AndreyAkinshin AndreyAkinshin added this to the v0.10.10 milestone Aug 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment