New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project files cleanup #549

Merged
merged 2 commits into from Sep 18, 2017

Conversation

Projects
None yet
4 participants
@Ky7m
Collaborator

Ky7m commented Sep 17, 2017

Main changes:

  • Remove PackageTargetFallback element (I guess that all required dependencies have an updated TFM already).
  • Replace TargetFramework with TargetFrameworkIdentifier to simplify conditions.
  • Unify TargetFrameworks definition.
  • Small fix of warning during compilation caused by typo with the XML tag. (diff)

Please pay attention to this change, was it a correct assumption?

Ky7m added some commits Sep 17, 2017

Remove PackageTargetFallback element.
Replace TargetFramework with TargetFrameworkIdentifier to simplify conditions.
Unify TargetFrameworks definition.
@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Sep 17, 2017

@Ky7m,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

dnfclas commented Sep 17, 2017

@Ky7m,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

@AndreyAkinshin

This comment has been minimized.

Show comment
Hide comment
@AndreyAkinshin

AndreyAkinshin Sep 18, 2017

Member

@Ky7m, thanks, LGTM!

Member

AndreyAkinshin commented Sep 18, 2017

@Ky7m, thanks, LGTM!

@AndreyAkinshin AndreyAkinshin merged commit 174c19d into dotnet:master Sep 18, 2017

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@AndreyAkinshin AndreyAkinshin added this to the v0.10.10 milestone Sep 18, 2017

@adamsitnik

This comment has been minimized.

Show comment
Hide comment
@adamsitnik

adamsitnik Sep 18, 2017

Member

great job! thanks!

Member

adamsitnik commented Sep 18, 2017

great job! thanks!

@Ky7m Ky7m deleted the Ky7m:csproj-files-cleanup branch Sep 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment