Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Single point of full config creation #565
The fix is following:
As a bonus I've added a
P.S. The build fails due to 9076a69 commit, branch build is fine, https://ci.appveyor.com/project/ig-sinicyn/benchmarkdotnet/build/0.10.9.47
I like the idea of
ReadOnlyConfig but I am not sure if the fact that we created config few times was a problem. On the other hand you want to change a contract of public methods here.
@AndreyAkinshin what do you think? I am not sure if the gain is big enough to merge it.
@ig-sinicyn could you create an issue next time before creating the PR?
Well, there is a problem with custom config attributes. Multiple calls of the same attribute will add multiple instances of logger/exporter/diagnoser etc into resulting config and there's no code that removes duplicates from resulting code. This may be fixed by altering the
Technically, both of these may be fixed without changing the public API. But without explicit API contract it is very easy to broke fixed behavior accidentally, just by calling overload that calls
I did not fix it as I'm not sure how to implement duplicate detection. Should all items expose smth like