Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Producing the asm diff reports on demand - fix for #936 #937

Merged
merged 4 commits into from Oct 31, 2018

Conversation

WojciechNagorski
Copy link
Contributor

@adamsitnik fix for #936.

@adamsitnik
Copy link
Member

@wojtpl2 thank you! could you please solve the merge conflict?

@adamsitnik adamsitnik self-requested a review October 31, 2018 16:31
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

* `-d`, `--disassm`- enables DisassemblyDiagnoser and exports diassembly of benchmarked code
* `-d`, `--disasm`- enables DisassemblyDiagnoser and exports diassembly of benchmarked code. When you enable this option, you can use:
- `--disasmDepth` - Sets the recursive depth for the disassembler.
- `--disasmDiff` - Generates diff reports for the disassembler.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating the docs! 🥇

@adamsitnik
Copy link
Member

btw the CI failure is not related to your changes, I hope that I have fixed it in #935

@adamsitnik
Copy link
Member

I have solved the conflict from GH web page UI. I had no idea it is so easy! sorry for bothering you @wojtpl2

@adamsitnik adamsitnik merged commit dd103b6 into dotnet:master Oct 31, 2018
@AndreyAkinshin AndreyAkinshin added this to the v0.11.2 milestone Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants