Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Producing the asm diff reports on demand - fix for #936 #937

Merged
merged 4 commits into from Oct 31, 2018

Conversation

@WojciechNagorski
Copy link
Collaborator

@WojciechNagorski WojciechNagorski commented Oct 31, 2018

@adamsitnik fix for #936.

@adamsitnik
Copy link
Member

@adamsitnik adamsitnik commented Oct 31, 2018

@wojtpl2 thank you! could you please solve the merge conflict?

@adamsitnik adamsitnik self-requested a review Oct 31, 2018
Copy link
Member

@adamsitnik adamsitnik left a comment

LGTM!

* `-d`, `--disassm`- enables DisassemblyDiagnoser and exports diassembly of benchmarked code
* `-d`, `--disasm`- enables DisassemblyDiagnoser and exports diassembly of benchmarked code. When you enable this option, you can use:
- `--disasmDepth` - Sets the recursive depth for the disassembler.
- `--disasmDiff` - Generates diff reports for the disassembler.

This comment has been minimized.

@adamsitnik

adamsitnik Oct 31, 2018
Member

thanks for updating the docs! 🥇

@adamsitnik
Copy link
Member

@adamsitnik adamsitnik commented Oct 31, 2018

btw the CI failure is not related to your changes, I hope that I have fixed it in #935

@adamsitnik
Copy link
Member

@adamsitnik adamsitnik commented Oct 31, 2018

I have solved the conflict from GH web page UI. I had no idea it is so easy! sorry for bothering you @wojtpl2

@adamsitnik adamsitnik merged commit dd103b6 into dotnet:master Oct 31, 2018
4 checks passed
4 checks passed
@wip
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@AndreyAkinshin AndreyAkinshin added this to the v0.11.2 milestone Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants