New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to stop running when the first benchmark fails #947

Merged
merged 1 commit into from Nov 14, 2018

Conversation

Projects
None yet
3 participants
@wojtpl2
Collaborator

wojtpl2 commented Nov 6, 2018

Fixes for #939
I'm not sure all of my changes, especially adding property and changing constructor in BenchmarkReport.

@wojtpl2

This comment has been minimized.

Collaborator

wojtpl2 commented Nov 6, 2018

@adamsitnik I've also added --stopOnFirstError command line argument.

@AndreyAkinshin

LGTM

@AndreyAkinshin AndreyAkinshin requested a review from adamsitnik Nov 14, 2018

@AndreyAkinshin

This comment has been minimized.

Member

AndreyAkinshin commented Nov 14, 2018

Could you please also review this PR?

@adamsitnik

LGTM!

@wojtpl2 big thanks for another good PR and sorry for the delay with code review!

@adamsitnik adamsitnik merged commit 9f33f0d into dotnet:master Nov 14, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details

@AndreyAkinshin AndreyAkinshin added this to the v0.11.3 milestone Nov 14, 2018

@wojtpl2 wojtpl2 deleted the wojtpl2:issue_939 branch Nov 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment