New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop benchmark after closing application + Flush log after stopping benchmark. #963

merged 1 commit into from Nov 16, 2018


None yet
2 participants

wojtpl2 commented Nov 16, 2018

Fixes for #885

In this PR I did:

@AndreyAkinshin AndreyAkinshin requested a review from adamsitnik Nov 16, 2018


LGTM! Great job!

Btw in the future, we could create a cross-platform event handler for this kind of events. Today we have similar logic here and in NativeWindowsConsoleHelper.

@adamsitnik adamsitnik merged commit 6c4a593 into dotnet:master Nov 16, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
license/cla All CLA requirements met.

@adamsitnik adamsitnik added this to the v0.11.3 milestone Nov 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment