Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 25, 2025

  • Explore the repository and understand the structure
  • Review existing breaking change documentation patterns
  • Review the related issue (#35757) and PR (#35724) to understand the breaking change
  • Add a new breaking change entry for IRelationalCommandDiagnosticsLogger in the summary table
  • Add a detailed breaking change section following the standard pattern
  • Review and validate the changes
  • Address PR feedback: rename anchor and fix table alignment
Original prompt

This section details on the original issue you should resolve

<issue_title>IRelationalCommandDiagnosticsLogger CommandReaderExecuting adds logCommandText parameter</issue_title>
<issue_description>### Type of issue

Missing information

Description

In breaking changes for Entity Framework .NET 10, someone forgot that there is a new required parameter for "logCommandText" in the interface named IRelationalCommandDiagnosticsLogger when calling a number of methods, one of which is CommandReaderExecuting.

I need to know what that parameter is for since it is not nullable and I am already passing in the command as a parameter.

Page URL

https://learn.microsoft.com/en-us/ef/core/what-is-new/ef-core-10.0/breaking-changes

Content source URL

https://github.com/dotnet/EntityFramework.Docs/blob/main/entity-framework/core/what-is-new/ef-core-10.0/breaking-changes.md

Document Version Independent Id

bbde202d-67a5-fa94-03cd-8a526a1f2a56

Platform Id

9992e66c-a232-bf52-db0b-d236573bddb5

Article author

@roji</issue_description>

<agent_instructions>Please add a low-impact breaking change note to the 10.0 breaking changes page (https://github.com/dotnet/EntityFramework.Docs/blob/main/entity-framework/core/what-is-new/ef-core-10.0/breaking-changes.md), following the pattern of the other breaking change notes. The relevant issue that introduced the breaking change is dotnet/efcore#35757, and the PR is dotnet/efcore#35724.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@roji Can you provide a bit of context on why this is breaking for you, i.e. how you're using the IRelationalCommandDiagnosticsLogger interface? @roji Yes, logCommandText is what gets logged, as opposed to what gets executed; this supports the new "redact inlined constants' feature introduced in EF 10 ([release notes](https://learn.microsoft.com/en-us/ef/core/what-is-new/ef-core-10.0/whatsnew#redact-inlined-constants-from-logging-by-default)).

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…gger logCommandText parameter

Co-authored-by: roji <1862641+roji@users.noreply.github.com>
Copilot AI changed the title [WIP] Add logCommandText parameter to CommandReaderExecuting Document IRelationalCommandDiagnosticsLogger.logCommandText parameter breaking change Nov 25, 2025
Copilot AI requested a review from roji November 25, 2025 20:15
Co-authored-by: roji <1862641+roji@users.noreply.github.com>
Copilot AI requested a review from roji November 25, 2025 20:51
@roji roji marked this pull request as ready for review November 25, 2025 21:01
@roji roji requested a review from a team November 25, 2025 21:01
@roji roji enabled auto-merge (squash) November 25, 2025 21:01
@roji roji merged commit f6f589a into main Nov 25, 2025
5 checks passed
@roji roji deleted the copilot/add-log-command-text-parameter branch November 25, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IRelationalCommandDiagnosticsLogger CommandReaderExecuting adds logCommandText parameter

3 participants